Re: [Syllable-kernel] SMP: -O1 vs. -O2

[Kristian V. D. V. <va...@li...>]

On Tuesday 19 October 2004 2:53 am, Jake Hamby wrote:
> Kristian Van Der Vliet wrote:
>> Attached is the result of tonights work.  I've identified smp.c as the
>> culprit (Makes sense, at least)  I was working with the stock 0.5.4
>> source which did not include your previous patches for -O2, so I've used
>> -O3 and -O1, although I will confirm tommorrow with -O1 and -O2 just to
>> be 100% sure.
>
> Well, there is at least one small bug which could break a -O3 build:
> the read_cpu_id() function is modifying the %ebx register but doesn't
> tell GCC that it is.  I've attached a patch.  That still doesn't explain
> why a -O2 build is also failing.  I'll keep looking at it...

Even though I don't pretend to fully understand it, the patch looks sensible 
enough and has been applied.  It does not fix an -O3 kernel  but it doesn't 
break anything either.

-- 
Vanders
http://syllable.sourceforge.net/
http://www.liqwyd.com