sword-app-tech

[sword-app-tech] logging levels

[Antony C. [awc] <aw...@ab...>]

Any chance of  lowering some of the logging levels in the Client class
to debug?

E.g.
log. info("server: " + server + " port: " + port + " u: '" + username +
"' p '" + password + "'");
log. info("returned message is: " + message);


Regards,
Antony
--
Antony Corfield
ROAD Project
http://road.aber.ac.uk

Re: [sword-app-tech] logging levels

[Jim D. <oj...@ca...>]

On 24/01/2008, Antony Corfield [awc] <aw...@ab...> wrote:
> Any chance of  lowering some of the logging levels in the Client class to
> debug?

Sure. Any chance of a patch with the mods you think appropriate?

jim

Re: [sword-app-tech] logging levels

[Antony C. [awc] <aw...@ab...>]

WWVwIGNoYW5nZSBsb2cuaW5mbyB0byBsb2cuZGVidWcgaW4gdGhlIHR3byBlLmcuIGxpbmVzIEkg
anVzdCBlbWFpbGVkIDstKQ0KDQotLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KRnJvbTogamlt
LmRvd25pbmdAZ21haWwuY29tIFttYWlsdG86amltLmRvd25pbmdAZ21haWwuY29tXSBPbiBCZWhh
bGYgT2YgSmltIERvd25pbmcNClNlbnQ6IDI0IEphbnVhcnkgMjAwOCAxNjo1NQ0KVG86IEFudG9u
eSBDb3JmaWVsZCBbYXdjXQ0KQ2M6IHN3b3JkLWFwcC10ZWNoQGxpc3RzLnNvdXJjZWZvcmdlLm5l
dA0KU3ViamVjdDogUmU6IFtzd29yZC1hcHAtdGVjaF0gbG9nZ2luZyBsZXZlbHMNCg0KT24gMjQv
MDEvMjAwOCwgQW50b255IENvcmZpZWxkIFthd2NdIDxhd2NAYWJlci5hYy51az4gd3JvdGU6DQo+
IEFueSBjaGFuY2Ugb2YgIGxvd2VyaW5nIHNvbWUgb2YgdGhlIGxvZ2dpbmcgbGV2ZWxzIGluIHRo
ZSBDbGllbnQgY2xhc3MgdG8NCj4gZGVidWc/DQoNClN1cmUuIEFueSBjaGFuY2Ugb2YgYSBwYXRj
aCB3aXRoIHRoZSBtb2RzIHlvdSB0aGluayBhcHByb3ByaWF0ZT8NCg0KamltDQo=

Re: [sword-app-tech] logging levels

[Jim D. <jim...@po...>]

On 24/01/2008, Antony Corfield [awc] <aw...@ab...> wrote:
>
> Any chance of  lowering some of the logging levels in the Client class to
> debug?

Sure, any chance of a patch with the changes you think appropriate?

jim

Re: [sword-app-tech] logging levels

[Antony C. [awc] <aw...@ab...>]

SGVyZSdzIGEgcGF0Y2ggZm9yIHRoZSBsb2dnaW5nIGNoYW5nZXMgLSB1c2VyL3Bhc3N3b3JkIG9u
bHkgbG9nZ2VkIHdoZW4gd2hlbiBzZXQgdG8gZGVidWcNCg0KamF2YS90cnVuay9zcmMvb3JnL3B1
cmwvc3dvcmQvY2xpZW50L0NsaWVudC5qYXZhDQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09DQotLS0gamF2YS90cnVuay9z
cmMvb3JnL3B1cmwvc3dvcmQvY2xpZW50L0NsaWVudC5qYXZhCShyZXZpc2lvbiAzNykNCisrKyBq
YXZhL3RydW5rL3NyYy9vcmcvcHVybC9zd29yZC9jbGllbnQvQ2xpZW50LmphdmEJKHdvcmtpbmcg
Y29weSkNCkBAIC0xMjUsOCArMTI1LDggQEANCiAgICB7DQogICAgICAgY2xpZW50ID0gbmV3IEh0
dHBDbGllbnQoKTsgDQogICAgICAgY2xpZW50LmdldFBhcmFtcygpLnNldFBhcmFtZXRlcigiaHR0
cC5zb2NrZXQudGltZW91dCIsIG5ldyBJbnRlZ2VyKERFRkFVTFRfVElNRU9VVCkpOw0KLSAgICAg
IGxvZy5pbmZvKCJwcm94eSBob3N0OiAiICsgY2xpZW50LmdldEhvc3RDb25maWd1cmF0aW9uKCku
Z2V0UHJveHlIb3N0KCkpOw0KLSAgICAgIGxvZy5pbmZvKCJwcm94eSBwb3J0OiAiICsgY2xpZW50
LmdldEhvc3RDb25maWd1cmF0aW9uKCkuZ2V0UHJveHlQb3J0KCkpOw0KKyAgICAgIGxvZy5kZWJ1
ZygicHJveHkgaG9zdDogIiArIGNsaWVudC5nZXRIb3N0Q29uZmlndXJhdGlvbigpLmdldFByb3h5
SG9zdCgpKTsNCisgICAgICBsb2cuZGVidWcoInByb3h5IHBvcnQ6ICIgKyBjbGllbnQuZ2V0SG9z
dENvbmZpZ3VyYXRpb24oKS5nZXRQcm94eVBvcnQoKSk7DQogICAgICAgZG9BdXRoZW50aWNhdGlv
biA9IGZhbHNlOyAgDQogICAgfQ0KIA0KQEAgLTE2NCw3ICsxNjQsNyBAQA0KICAgICAqLw0KICAg
IHByaXZhdGUgdm9pZCBzZXRCYXNpY0NyZWRlbnRpYWxzKCBTdHJpbmcgdXNlcm5hbWUsIFN0cmlu
ZyBwYXNzd29yZCApDQogICAgew0KLSAgICAgIGxvZy5pbmZvKCJzZXJ2ZXI6ICIgKyBzZXJ2ZXIg
KyAiIHBvcnQ6ICIgKyBwb3J0ICsgIiB1OiAnIiArIHVzZXJuYW1lICsgIicgcCAnIiArIHBhc3N3
b3JkICsgIiciKTsNCisgICAgICBsb2cuZGVidWcoInNlcnZlcjogIiArIHNlcnZlciArICIgcG9y
dDogIiArIHBvcnQgKyAiIHU6ICciICsgdXNlcm5hbWUgKyAiJyBwICciICsgcGFzc3dvcmQgKyAi
JyIpOw0KICAgICAgIGNsaWVudC5nZXRTdGF0ZSgpLnNldENyZWRlbnRpYWxzKA0KICAgICAgICAg
ICAgIG5ldyBBdXRoU2NvcGUoc2VydmVyLCBwb3J0KSwgDQogICAgICAgICAgICAgbmV3IFVzZXJu
YW1lUGFzc3dvcmRDcmVkZW50aWFscyh1c2VybmFtZSwgcGFzc3dvcmQpKTsNCkBAIC0yNjMsNyAr
MjYzLDcgQEANCiAgICAgICAvLyBpZiAoKCBvbkJlaGFsZk9mICE9IG51bGwgKSAmJiAoICEgb25C
ZWhhbGZPZi50cmltKCkuZXF1YWxzKCIiKSApKSANCiAgICAgICBpZiggY29udGFpbnNWYWx1ZShv
bkJlaGFsZk9mKSApDQogICAgICAgew0KLSAgICAgICAgIGxvZy5pbmZvKCJTZXR0aW5nIG9uLWJl
aGFsZi1vZjogIiArIG9uQmVoYWxmT2YgKTsNCisgICAgICAgICBsb2cuZGVidWcoIlNldHRpbmcg
b24tYmVoYWxmLW9mOiAiICsgb25CZWhhbGZPZiApOw0KICAgICAgICAgIGh0dHBnZXQuYWRkUmVx
dWVzdEhlYWRlciggbmV3IEhlYWRlciggSHR0cEhlYWRlcnMuWF9PTl9CRUhBTEZfT0YsIG9uQmVo
YWxmT2YgKSApOyAgICAgIA0KICAgICAgIH0NCiANCkBAIC0yNzksNyArMjc5LDcgQEANCiAgICAg
ICAgICBpZiggc3RhdHVzLmdldENvZGUoKSA9PSBIdHRwU3RhdHVzLlNDX09LICkgDQogICAgICAg
ICAgew0KICAgICAgICAgICAgIFN0cmluZyBtZXNzYWdlID0gcmVhZFJlc3BvbnNlKGh0dHBnZXQu
Z2V0UmVzcG9uc2VCb2R5QXNTdHJlYW0oKSk7DQotICAgICAgICAgICAgbG9nLmluZm8oInJldHVy
bmVkIG1lc3NhZ2UgaXM6ICIgKyBtZXNzYWdlKTsNCisgICAgICAgICAgICBsb2cuZGVidWcoInJl
dHVybmVkIG1lc3NhZ2UgaXM6ICIgKyBtZXNzYWdlKTsNCiAgICAgICAgICAgICANCiAgICAgICAg
ICAgICBkb2MgPSBuZXcgU2VydmljZURvY3VtZW50KCk7IA0KICAgICAgICAgICAgIGRvYy51bm1h
cnNoYWxsKG1lc3NhZ2UpOw0KDQoNCi0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQpGcm9tOiBq
aW0uZG93bmluZ0BnbWFpbC5jb20gW21haWx0bzpqaW0uZG93bmluZ0BnbWFpbC5jb21dIE9uIEJl
aGFsZiBPZiBKaW0gRG93bmluZw0KU2VudDogMjQgSmFudWFyeSAyMDA4IDE2OjU1DQpUbzogQW50
b255IENvcmZpZWxkIFthd2NdDQpDYzogc3dvcmQtYXBwLXRlY2hAbGlzdHMuc291cmNlZm9yZ2Uu
bmV0DQpTdWJqZWN0OiBSZTogW3N3b3JkLWFwcC10ZWNoXSBsb2dnaW5nIGxldmVscw0KDQpPbiAy
NC8wMS8yMDA4LCBBbnRvbnkgQ29yZmllbGQgW2F3Y10gPGF3Y0BhYmVyLmFjLnVrPiB3cm90ZToN
Cj4gQW55IGNoYW5jZSBvZiAgbG93ZXJpbmcgc29tZSBvZiB0aGUgbG9nZ2luZyBsZXZlbHMgaW4g
dGhlIENsaWVudCBjbGFzcyB0bw0KPiBkZWJ1Zz8NCg0KU3VyZS4gQW55IGNoYW5jZSBvZiBhIHBh
dGNoIHdpdGggdGhlIG1vZHMgeW91IHRoaW5rIGFwcHJvcHJpYXRlPw0KDQpqaW0NCg==

Re: [sword-app-tech] logging levels

[Jim D. <oj...@ca...>]

Applied and committed, thanks!

jim

On 25/01/2008, Antony Corfield [awc] <aw...@ab...> wrote:
> Here's a patch for the logging changes - user/password only logged when when set to debug
>
> java/trunk/src/org/purl/sword/client/Client.java
> ===================================================================
> --- java/trunk/src/org/purl/sword/client/Client.java    (revision 37)
> +++ java/trunk/src/org/purl/sword/client/Client.java    (working copy)
> @@ -125,8 +125,8 @@
>     {
>        client = new HttpClient();
>        client.getParams().setParameter("http.socket.timeout", new Integer(DEFAULT_TIMEOUT));
> -      log.info("proxy host: " + client.getHostConfiguration().getProxyHost());
> -      log.info("proxy port: " + client.getHostConfiguration().getProxyPort());
> +      log.debug("proxy host: " + client.getHostConfiguration().getProxyHost());
> +      log.debug("proxy port: " + client.getHostConfiguration().getProxyPort());
>        doAuthentication = false;
>     }
>
> @@ -164,7 +164,7 @@
>      */
>     private void setBasicCredentials( String username, String password )
>     {
> -      log.info("server: " + server + " port: " + port + " u: '" + username + "' p '" + password + "'");
> +      log.debug("server: " + server + " port: " + port + " u: '" + username + "' p '" + password + "'");
>        client.getState().setCredentials(
>              new AuthScope(server, port),
>              new UsernamePasswordCredentials(username, password));
> @@ -263,7 +263,7 @@
>        // if (( onBehalfOf != null ) && ( ! onBehalfOf.trim().equals("") ))
>        if( containsValue(onBehalfOf) )
>        {
> -         log.info("Setting on-behalf-of: " + onBehalfOf );
> +         log.debug("Setting on-behalf-of: " + onBehalfOf );
>           httpget.addRequestHeader( new Header( HttpHeaders.X_ON_BEHALF_OF, onBehalfOf ) );
>        }
>
> @@ -279,7 +279,7 @@
>           if( status.getCode() == HttpStatus.SC_OK )
>           {
>              String message = readResponse(httpget.getResponseBodyAsStream());
> -            log.info("returned message is: " + message);
> +            log.debug("returned message is: " + message);
>
>              doc = new ServiceDocument();
>              doc.unmarshall(message);
>
>
> -----Original Message-----
> From: jim...@gm... [mailto:jim...@gm...] On Behalf Of Jim Downing
> Sent: 24 January 2008 16:55
> To: Antony Corfield [awc]
> Cc: swo...@li...
> Subject: Re: [sword-app-tech] logging levels
>
> On 24/01/2008, Antony Corfield [awc] <aw...@ab...> wrote:
> > Any chance of  lowering some of the logging levels in the Client class to
> > debug?
>
> Sure. Any chance of a patch with the mods you think appropriate?
>
> jim
>