Re: [sword-app-tech] logging levels

[Jim D. <oj...@ca...>]

Applied and committed, thanks!

jim

On 25/01/2008, Antony Corfield [awc] <aw...@ab...> wrote:
> Here's a patch for the logging changes - user/password only logged when when set to debug
>
> java/trunk/src/org/purl/sword/client/Client.java
> ===================================================================
> --- java/trunk/src/org/purl/sword/client/Client.java    (revision 37)
> +++ java/trunk/src/org/purl/sword/client/Client.java    (working copy)
> @@ -125,8 +125,8 @@
>     {
>        client = new HttpClient();
>        client.getParams().setParameter("http.socket.timeout", new Integer(DEFAULT_TIMEOUT));
> -      log.info("proxy host: " + client.getHostConfiguration().getProxyHost());
> -      log.info("proxy port: " + client.getHostConfiguration().getProxyPort());
> +      log.debug("proxy host: " + client.getHostConfiguration().getProxyHost());
> +      log.debug("proxy port: " + client.getHostConfiguration().getProxyPort());
>        doAuthentication = false;
>     }
>
> @@ -164,7 +164,7 @@
>      */
>     private void setBasicCredentials( String username, String password )
>     {
> -      log.info("server: " + server + " port: " + port + " u: '" + username + "' p '" + password + "'");
> +      log.debug("server: " + server + " port: " + port + " u: '" + username + "' p '" + password + "'");
>        client.getState().setCredentials(
>              new AuthScope(server, port),
>              new UsernamePasswordCredentials(username, password));
> @@ -263,7 +263,7 @@
>        // if (( onBehalfOf != null ) && ( ! onBehalfOf.trim().equals("") ))
>        if( containsValue(onBehalfOf) )
>        {
> -         log.info("Setting on-behalf-of: " + onBehalfOf );
> +         log.debug("Setting on-behalf-of: " + onBehalfOf );
>           httpget.addRequestHeader( new Header( HttpHeaders.X_ON_BEHALF_OF, onBehalfOf ) );
>        }
>
> @@ -279,7 +279,7 @@
>           if( status.getCode() == HttpStatus.SC_OK )
>           {
>              String message = readResponse(httpget.getResponseBodyAsStream());
> -            log.info("returned message is: " + message);
> +            log.debug("returned message is: " + message);
>
>              doc = new ServiceDocument();
>              doc.unmarshall(message);
>
>
> -----Original Message-----
> From: jim...@gm... [mailto:jim...@gm...] On Behalf Of Jim Downing
> Sent: 24 January 2008 16:55
> To: Antony Corfield [awc]
> Cc: swo...@li...
> Subject: Re: [sword-app-tech] logging levels
>
> On 24/01/2008, Antony Corfield [awc] <aw...@ab...> wrote:
> > Any chance of  lowering some of the logging levels in the Client class to
> > debug?
>
> Sure. Any chance of a patch with the mods you think appropriate?
>
> jim
>