Re: [Swingosc-devel] patch for EZ behaviour

[nescivi <ne...@gm...>]

Hiho,


On 4/12/09, Sciss <co...@sc...> wrote:
> hi marije,
>
> there is a lot of problems with your diff, mainly because you are
> reverting a lot of class files to previous versions and thereby
> undoing a lot of recent changes and fixes!
>
> - first, in the build.xml script:
>
> "/usr/share/java/ant-contrib-1.0b3.jar"/
>
> that doesn't look like it will help many people, unless they have
> exactly the same version installed... does it do any harm if that jar
> file is not there?

Ok, this one should not be part of the diff.
I need this fix to get it to build on my system, but I will of course
keep this out of the svn version.


> - in JSCView.sc you are undoing the fixes to JSCTopView
> (absoluteBounds and the fix for relativeOrigin_( false )) :
>
>   /**
> - *	@version		0.61, 11-Apr-09
> + *	@version		0.61, 13-Jan-09
>    *	@author		Hanns Holger Rutz
>    */
>   JSCContainerView : JSCView { // abstract class
> @@ -330,8 +330,6 @@
>   		});
>   	}
>
> -	absoluteBounds { ^this.bounds }
>
> -
> -	prBoundsReadOnly {
> -		if( scBounds.isNil, {
> -			// need to revalidate bounds
> -			scBounds	= jinsets.addTo( jBounds );
> -		});
> -		^scBounds;
> -	}
>
>
> - same with JSCDragView:
>
> -	var <>interpretDroppedStrings = false;
> +	var <>interpretDroppedStrings = true;
>
> - ... and JSCTextField
>
>   	open { arg path;
> -		var file;
> -		if( path.beginsWith( "SC://" ), {
> -			path = Help.findHelpFile( path.copyToEnd( 5 ));
> -		}, {
> -			path = path.absolutePath;
> +		Platform.case(\windows, {
> +			if(path[1]==$:){
> +				// Windows path styles "C:\blah" will need an extra slash at start
> +				path = "/" ++ path
> +			};
> +			path = path.tr($\\, $/);
>   		});
> -		server.sendMsg( '/method', this.id, \setPage, '[', '/methodr',
> '[', '/new', "java.io.File", path, ']', 'toURL', ']' );
> +		path = path.replace( ' ', '%20' );
> +
> +		if ( path.contains( "SC://"), {
> +			path = Help.findHelpFile( path.asRelativePath( "SC:/") );
> +		});
> +
> +		if ( path.contains( "://" ).not, {
> +			if ( path.first.asString != "/" ) { path = String.scDir +/+ path; };
> +			path = "file://"++path;
> +		});
> +		this.openURL( path );
>   	}
>
> your patch will try to revert to old behaviour. this is wrong in all
> cases. again: please work with the most recent class files! please
> just adjust the increment / scroll etc. methods.
>
> - there is more cases, e.g. JSCEnvelopeView, where you have been
> working with an obsolete version. your diff will remove the additions
> and fixes to JSCEnvelopeView.
>
> so if you go again from the latest class files and apply the new
> scroll / increment methods, i think it's ok + good!

Ok, AdC did not have the most recent files.

I'll get a proper diff.

sincerely,
Marije