On 28 November 2011 17:08, swig's commit hook wrote:
> Revision: 12846
> Author: olly
> Date: 2011-11-28 04:08:25 +0000 (Mon, 28 Nov 2011)
> Log Message:
> [PHP] Don't generate "return $r;" in cases where $r hasn't been set.
> This was basically harmless, except it generated a PHP E_NOTICE if
> the calling code had enabled them.
> Modified Paths:
Sorry, my first attempt to commit this failed (thanks to SF forcing a
password reset after a breakin
while back), and after sorting that out I reran it with the saved
commit message, but clearly gave it
the wrong filename...
This is a minor portability fix - isdigit() (and friends) are only
portably defined for unsigned char
values (though glibc extends them to work for signed char too) so this
fixes this code to handle
top bit set characters on non-glibc platforms where char is signed by default.