On Tue, May 26, 2009 at 07:23:31AM -0600, David Fletcher <frodo@...> wrote:
> MV> Did you read the patch before sending? :)
> I'm not sure what you're asking. Would you rephrase your question?
I meant to say that you modify the file, then 'svn diff > foo.patch' and
just send foo.patch or you read foo.patch first to see "oh, I left there
an unnecessary #ifdef".
> 5. For a final patch, I would, of course, remove the "#if 1" construct
> you mentioned. And, while it pains me, I'd also change the code to
> match the coding style used within SWIG.
Okay, sorry - I did not meant to insult you, I just thought you send the
patch for inclusion, and that's why I pointed out those style issue.