From: David Fletcher <frodo@tu...> - 2009-05-26 14:45:39
>>>>> "MV" == Miklos Vajna <vmiklos@...> writes:
>> I'm not sure what you're asking. Would you rephrase your question?
MV> I meant to say that you modify the file, then 'svn diff >
MV> foo.patch' and just send foo.patch or you read foo.patch first to
MV> see "oh, I left there an unnecessary #ifdef".
Ah. I did the "svn diff" thing. I didn't read the patch carefully,
because it wasn't meant as a final patch.
Thanks for clarifying.
>> 5. For a final patch, I would, of course, remove the "#if 1" construct
>> you mentioned. And, while it pains me, I'd also change the code to
>> match the coding style used within SWIG.
MV> Okay, sorry - I did not meant to insult you, I just thought you
MV> send the patch for inclusion, and that's why I pointed out those
MV> style issue.
I wasn't insulted. :-)
(It would take a lot to insult me. And, I welcome any and all