On Fri, Sep 25, 2009 at 9:55 AM, Marko Klopcic <marko.klopcic@isystem.si> wrote:
> On 2009-09-22, William S Fulton <wsf@fultondesigns.co.uk> wrote:
>> Where is the patch? I must of overlooked notification of this. We are
>> interested in development of this functionality, so please let us know
>> about your improvements. All I can see is an email of yours from 9 April
>> this year, but no follow up.
> The patch is in the SF bugtracker, but it's large and combines reformatting
> changes with actual fixes.  The reformatting is probably an improvement,
> but mixing the two makes the patch substantially harder to review and I
> simply haven't had the time to do so yet.
> I know that's not great, but I can't magically create more spare time, and
> it's not exactly a new idea that a patch should embody a single logical
> change.

As mentioned in the last comment to the patch, I recommend to carefully
review only changes outside the DoxygenTranslator dir. There are only few
changes and almost no formatting changed.

Files in DoxygenTranslator were changed significantly. It doesn't make sense
to review them carefully, because comment translation was almost
useless before changes. These files also do not affect other parts of
doxygen functionality. It'd be better to compile and test it.

I'm sorry about formatting changes, but it is much easier to understand
the code if it is readable. Next time I'll ask for a review before making
real changes :-(

Is there any way I can help with getting the patch assessed? I've checked it out and it does seem to be working better than the unpatched GSOC branch, though not completely bug-free. (Still drops some comments and passes unsanitized inputs into Printf)