#898 Makefile Broken in 1.3.34

closed-fixed
5
2008-03-17
2008-02-28
No

I just grabbed the new 1.3.34 release. On Mac OS X (at the very least)

%: ./configure
....

%: make
Makefile:215: *** missing separator. Stop.
make: *** [source] Error 2
%: head -215 Makefile | tail -1
check-php4-test-suite \

I re-ran autogen.sh and the same error occurred.

Discussion

  • Russell Bryant

    Russell Bryant - 2008-02-28

    Logged In: YES
    user_id=1942915
    Originator: NO

    Hm ... it's working fine for me on both linux and Mac OS X.

    What version of Mac OS X? Also, what version of GNU make are you using (make --version) ?

    I'm using an up to date version of 10.4 on a PPC mac. Also, I have GNU make 3.81 installed.

     
  • Geoff Hutchison

    Geoff Hutchison - 2008-02-28
     
  • Geoff Hutchison

    Geoff Hutchison - 2008-02-28

    Logged In: YES
    user_id=21420
    Originator: YES

    This is on Mac OS X 10.5.2 (make 3.81 from /usr/bin/make).

    I'm attaching my config.log. Perhaps it's because I have different languages installed than you? I don't have php4, for example.

    File Added: config.log

     
  • Geoff Hutchison

    Geoff Hutchison - 2008-02-28
     
  • Geoff Hutchison

    Geoff Hutchison - 2008-02-28

    Logged In: YES
    user_id=21420
    Originator: YES

    File Added: Makefile

     
  • William Fulton

    William Fulton - 2008-02-28

    Logged In: YES
    user_id=242951
    Originator: NO

    Is the behaviour different to version 1.3.33?

     
  • Geoff Hutchison

    Geoff Hutchison - 2008-02-29

    Logged In: YES
    user_id=21420
    Originator: YES

    I'll check on 1.3.33.

    I found the problem, though. It's not the top-level Makefile.
    The error occurs in Source/Makefile

    Line 215 in that file:
    PHP4 = php
    PHP4INC = Usage: php [options] [-f] <file> [--] [args...]
    php [options] -r <code> [--] [args...]

    Somehow my php4 isn't giving the result you expect. A bit of sleuthing indicates that PHP4CONFIG is getting set to 'php4' not 'php4-config'

    I can get the build to work with ./configure --without-php4 as a workaround for now.

     
  • David M. Beazley

    Logged In: YES
    user_id=7557
    Originator: NO

    I can confirm that this fails for me as well. OS-X, version 10.5.2. Does not break in SWIG-1.3.33.

    --Dave

     
  • Olly Betts

    Olly Betts - 2008-03-13

    Logged In: YES
    user_id=14972
    Originator: NO

    It seems likely that patch is to blame, but it seems to work for me (as I'd expect since I did test this before committing!)

    I wonder if it's a sed portability issue - can someone with OS X tell me what this command outputs:

    echo php|sed 's/\([45]\?\)$/-config\1/'

     
  • Olly Betts

    Olly Betts - 2008-03-17

    Logged In: YES
    user_id=14972
    Originator: NO

    OK, I checked the portability section of the autoconf manual, which says that \? isn't portable sed, and that \| may not be supported everywhere (which is annoying as that's the obvious alternative). I've reworked to avoid this issue and committed a fix.

     
  • Olly Betts

    Olly Betts - 2008-03-17
    • assigned_to: nobody --> olly
    • status: open --> closed-fixed
     
  • sky

    sky - 2008-03-28

    Logged In: YES
    user_id=1776307
    Originator: NO

    I also met this problem. my machine is Mac OS X 10.5.2, GNU Make 3.81, PPC mac.
    BTW, 1.3.33 is OK.

     
  • Olly Betts

    Olly Betts - 2008-03-28

    Logged In: YES
    user_id=14972
    Originator: NO

    It's already fixed in SVN, and so will be fixed in the next release (1.3.35).

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks