From: <sw...@sa...> - 2003-07-05 14:43:06
|
it seems the resampler cannot resample most mono files. i have no problems resampling any stereo ones. but most mono files I try will hang the resampler. -Dan |
From: Erik de C. L. <eri...@me...> - 2003-07-06 04:02:48
|
On Sat, 5 Jul 2003 07:43:14 -0700 (PDT) sw...@sa... wrote: > it seems the resampler cannot resample most mono files. > > i have no problems resampling any stereo ones. but most mono files I try > will hang the resampler. I've just tried this an I can't find any problem. I'm using sweep-0.8.2 libsamplerate-0.0.15 I tried a number of different files, a number of different conversion ratios and all three SRC converter types. Please check that you are using the above versions. If you are still having problems, please give details of the file you're having trouble with (maybe post the output of sndfile-info) and the settings you are using. It might also be worth putting the file on a web server and posting a link so I can try it here. Cheers, Erik -- +-----------------------------------------------------------+ Erik de Castro Lopo no...@me... (Yes it's valid) +-----------------------------------------------------------+ #!/bin/sh unzip ; strip; touch ; finger ; mount ; gasp ; yes ; more ; umount ; sleep ; |
From: <sw...@sa...> - 2003-07-12 12:40:28
|
On Sun, 6 Jul 2003, Erik de Castro Lopo wrote: > I've just tried this an I can't find any problem. I'm using > sweep-0.8.2 > libsamplerate-0.0.15 > I tried a number of different files, a number of different conversion ratios > and all three SRC converter types. > Please check that you are using the above versions. If you are still having > problems, please give details of the file you're having trouble with (maybe > post the output of sndfile-info) and the settings you are using. It might > also be worth putting the file on a web server and posting a link so I can > try it here. i confirmed sweep 0.8.2 and libsamplerate-0.0.15... and yes I am still having problems. http://bani.anime.net/hit1_4.wav mix down to mono -> normalize -> best sinc interpolator resample to 22050 -> hang mix down to mono -> normalize -> medium sinc interpolator resample to 22050 -> hang mix down to mono -> normalize -> fastest sinc interpolator resample to 22050 -> hang mix down to mono -> normalize -> bext sinc interpolator resample to 32000 -> works mix down to mono -> normalize -> bext sinc interpolator resample to 16000 -> works mix down to mono -> normalize -> bext sinc interpolator resample to 11025 -> hang mix down to mono -> normalize -> bext sinc interpolator resample to 8000 -> works mix down to mono -> normalize -> bext sinc interpolator resample to 4000 -> works mix down to mono -> normalize -> linear interpolator resample to 22050 -> works mix down to mono -> normalize -> zoh interpolator resample to 22050 -> works It seems there ar bugs with certain divisors in the sinc interpolator. I also discovered other strange bug... when you resample to very low rate (8khz or 4khz) and press play... the cursor moves quickly over the sample window, and the sound plays about 1-2 seconds later... -Dan |
From: Erik de C. L. <eri...@me...> - 2003-07-12 23:48:18
|
On Sat, 12 Jul 2003 05:40:16 -0700 (PDT) sw...@sa... wrote: > i confirmed sweep 0.8.2 and libsamplerate-0.0.15... and yes I am still > having problems. > > http://bani.anime.net/hit1_4.wav > > mix down to mono -> normalize -> > best sinc interpolator resample to 22050 -> hang Yep, I can confirm this. This is also unrelated to the "mix down to mono" operation. If you first mix down to mono, save the file and then work on the mono file from there on, there is still a problem. The strange thing is that the problem doesn't seem to happen with stereo files. I also tried taking the mono version of the file and resampling it to 22050Hz using the command line program sndfile-resample (one of the example programs in the libsamplrate package) where it works correctly. Finally, when I resample the mono file in Sweep, I notice that when it hangs, it starts chewing up CPU power suggesting that its caught in an infinite loop. This all suggests that Sweep is not using libsamplerate correctly. If I get some time over the next week I'll have a look at this. <snip> > I also discovered other strange bug... when you resample to very low rate > (8khz or 4khz) and press play... the cursor moves quickly over the sample > window, and the sound plays about 1-2 seconds later... Thats something Conrad shoud look at :-). Erik -- +-----------------------------------------------------------+ Erik de Castro Lopo no...@me... (Yes it's valid) +-----------------------------------------------------------+ Will the last person leaving Redmond please turn off all the lights. |
From: <sw...@sa...> - 2003-10-30 23:30:06
|
On Sun, 13 Jul 2003, Erik de Castro Lopo wrote: > On Sat, 12 Jul 2003 05:40:16 -0700 (PDT) > sw...@sa... wrote: > > mix down to mono -> normalize -> > > best sinc interpolator resample to 22050 -> hang > Yep, I can confirm this. > [...] > This all suggests that Sweep is not using libsamplerate correctly. If I > get some time over the next week I'll have a look at this. Has this been fixed yet? -Dan |
From: Erik de C. L. <eri...@me...> - 2003-11-01 01:26:37
|
On Thu, 30 Oct 2003 15:29:56 -0800 (PST) sw...@sa... wrote: > On Sun, 13 Jul 2003, Erik de Castro Lopo wrote: > > On Sat, 12 Jul 2003 05:40:16 -0700 (PDT) > > sw...@sa... wrote: > > > mix down to mono -> normalize -> > > > best sinc interpolator resample to 22050 -> hang > > Yep, I can confirm this. > > [...] > > This all suggests that Sweep is not using libsamplerate correctly. If I > > get some time over the next week I'll have a look at this. > > Has this been fixed yet? Probably not. I'll see if I can have a chance to look at it this weekend. Erik -- +-----------------------------------------------------------+ Erik de Castro Lopo no...@me... (Yes it's valid) +-----------------------------------------------------------+ "The happiness you have demanded is now mandatory." -- Jello Biafra |
From: Erik de C. L. <eri...@me...> - 2003-11-03 08:18:48
|
On Sat, 1 Nov 2003 12:26:36 +1100 Erik de Castro Lopo <eri...@me...> wrote: > Probably not. I'll see if I can have a chance to look at it this weekend. Here is a patch against 0.8.2. Seems to work here. Feedback to the list please. Erik --------------------------------------------------------------------- --- sweep-0.8.2/src/samplerate.c 2003-04-27 15:37:14.000000000 +1000 +++ sweep-0.8.2-hacked/src/samplerate.c 2003-11-03 16:13:51.000000000 +1100 @@ -114,7 +114,7 @@ old_sounddata = sample->sounddata; old_nr_frames = old_sounddata->nr_frames; - new_nr_frames = old_nr_frames * src_ratio; + new_nr_frames = floor (old_nr_frames * src_ratio) ; new_sounddata = sounddata_new_empty (old_format->channels, new_rate, new_nr_frames); @@ -138,7 +138,7 @@ /* XXX: move play/rec offsets */ /* Resample data */ - while (active && remaining > 0) { + while (active) { g_mutex_lock (sample->ops_mutex); if (sample->edit_state == SWEEP_EDIT_STATE_CANCEL) { @@ -175,6 +175,11 @@ offset_in += (sw_framecount_t)src_data.input_frames_used; offset_out += (sw_framecount_t)src_data.output_frames_gen; + + /* This is the normal loop exit point. */ + if (src_data.output_frames_gen == 0) { + active = FALSE; + } #ifdef DEBUG printf ("%ld ->\t%ld\t(%d)\n", src_data.input_frames_used, @@ -189,9 +194,13 @@ g_mutex_unlock (sample->ops_mutex); } - if (remaining > 0) { /* cancelled or failed */ + /* Only an error if remaining > 1 */ + if (remaining > 1) { /* cancelled or failed */ sounddata_destroy (new_sounddata); } else if (sample->edit_state == SWEEP_EDIT_STATE_BUSY) { + /* Set real number of frames. */ + new_sounddata->nr_frames = run_total ; + sample->sounddata = new_sounddata; inst->redo_data = inst->undo_data = --------------------------------------------------------------------- -- +-----------------------------------------------------------+ Erik de Castro Lopo no...@me... (Yes it's valid) +-----------------------------------------------------------+ The Earth is around 70% water. Fish rule the seas. Humans are over 90% water. It's only a matter of time. |
From: <sw...@sa...> - 2004-01-16 09:11:47
|
On Mon, 3 Nov 2003, Erik de Castro Lopo wrote: > On Sat, 1 Nov 2003 12:26:36 +1100 > Erik de Castro Lopo <eri...@me...> wrote: > > Probably not. I'll see if I can have a chance to look at it this weekend. > Here is a patch against 0.8.2. Seems to work here. > Feedback to the list please. that seems to have fixed it. |
From: Conrad P. <co...@me...> - 2004-04-28 10:31:05
|
On Fri, Jan 16, 2004 at 01:11:39AM -0800, sw...@sa... wrote: > On Mon, 3 Nov 2003, Erik de Castro Lopo wrote: > > On Sat, 1 Nov 2003 12:26:36 +1100 > > Erik de Castro Lopo <eri...@me...> wrote: > > > Probably not. I'll see if I can have a chance to look at it this weekend. > > Here is a patch against 0.8.2. Seems to work here. > > Feedback to the list please. > > that seems to have fixed it. gah, patch applied in cvs Conrad. -> faster than a dead fish |
From: Erik de C. L. <eri...@me...> - 2004-04-28 10:36:55
|
On Wed, 28 Apr 2004 20:30:56 +1000 Conrad Parker <co...@me...> wrote: > Conrad. > -> faster than a dead fish But only just!!!! ;-) Erik -- +-----------------------------------------------------------+ Erik de Castro Lopo no...@me... (Yes it's valid) +-----------------------------------------------------------+ "If POSIX threads are a good thing, perhaps I don't want to know what they're better than." -- Rob Pike |