A new Method like "getProtocol()" that returns the
current protocol as an addition to getHostName and
getAdminPort would be nice to avoid hard-coded"http://"
or similar.
I'm not sure why a getProtocol() method is necessary.
There're already two methods, getPublicURL() and
getAdminURL() that return the complete URL with protocol.
These methods return URLs that are created by the
ServentConfiguration class itself. Should the implementation
details change, the ServentConfiguration class would take
care of them (for instance, if the protocol ever changes).
It would cost close to zero to add such a method, but I
don't see why it is necessary. Of course, if it really is,
it will be added without much delay.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Logged In: YES
user_id=228477
I'm not sure why a getProtocol() method is necessary.
There're already two methods, getPublicURL() and
getAdminURL() that return the complete URL with protocol.
These methods return URLs that are created by the
ServentConfiguration class itself. Should the implementation
details change, the ServentConfiguration class would take
care of them (for instance, if the protocol ever changes).
It would cost close to zero to add such a method, but I
don't see why it is necessary. Of course, if it really is,
it will be added without much delay.