Handling of password file and acces file

[damaxl]

When installing SVNManager I ran into a problem with file access permission on Linux (Debian Etch).

That's what i did

- SVNManager -> User Admin -> Add a new user / Remove a user
- Fill out the form and send it
- PHP error message. PHP has no access to password file

The error came up because the passwordfile didn't have write permissions for Apache/SVNManager.

Now the system is in an inconsistent state. The user is added to / removed from the database but not added to /removed from the passwordfile.

This wouldn't be a problem if the system is installed well, but in the 'chaos' of all this new and unknown things it will make one sweat :-)

My suggestion is: before writing / removing anything into the database that even affects the password file or accesfile SVNManager should check the write permissions, display an error message and do nothing more if it has no permissions.

During my tests i found, that the access file maybe isn't managed well. If a group is defined and users are asigned to this group, this should result in an entry in the accessfile. But in the section [group] there only the groupname can be found.
For example: group = testers, user = user1 assigned to that group.
accessfile now look like this:

[groups]
testers =

but it should look like this:

[groups]
testers = user1

[Anonymous]

I created this file only using SVNManager. So there seems to be no problem with groups in the access-file.

>>>>>
[groups]
bla = chef

[test:/]
stefan = rw
@bla = r
<<<<<<

I created this with the following steps:
1. logged in as "stefan"
2. created repository "test"
3. created group "bla"
4. added "chef" to "bla" by "Edit group"
5. added "bla" to "test" by "Change group privilegs"

[damaxl]

Group Management

Sorry, I made a mistake in Group administration -> Change a Group. I didn't realize that I have to click on the user to select it and then click on Confirm, Because there were only 2 users in the list I wanted to be a member of the group anyway.