Bugfix for "Remove user Bug"

[kdre76]

Hi,

Bug description: When removing a User the user is not deleted in the htpasswd file.

The bug is in svnmanager/UserModule/DataModule.php
You queried the database for the user AFTER you deleted him ...

Here is the bugfixed version of the function deletUser:

        public function deleteUser($id)
        {
                require("config.php");

                //Change Groups
                $this->Database->Execute("UPDATE groups SET adminid='1' WHERE adminid='$id'");

                //Change Repositories
                $this->Database->Execute("UPDATE repositories SET ownerid='1' WHERE ownerid='$id'");

                //Remove user from group(s)
                $this->Database->Execute("DELETE FROM usersgroups WHERE userid='$id'");

                //Klaus Drechsler, 12.08.2005:
                //bugfix: select name was after the user has been deletetd
                $results = $this->Database->Execute("SELECT name FROM users WHERE id='$id'");
                $name = $results->fields['name'];

                //Remove user
                $this->Database->Execute("DELETE FROM users WHERE id='$id'");

                //$results = $this->Database->Execute("SELECT name FROM users WHERE id='$id'");
                //$name = $results->fields['name'];

                exec("$htpassword_cmd -D $svn_passwd_file $name");

                $this->rebuildAccessfile();
        }

Bye,
Klaus

[Marijn Verkerk]

Hi Klaus,

Thanks!

It will be incorporated in the next version!

Marijn