Grabled diacritics on email sent

[Seiti Yamashiro]

Hello!

I've been using this excelent tool for some days. It's really good and useful. Thanks!

But I found a bug. The email sent by svn-notify replaces diacritcs with incompreensible characters, such as:

AtualizaþÒo do Tema PadrÒo

That should be:

Atualização do Tema Padrão

Already downloaded the code from svn and fixed it. The patch is:

Index: SubversionNotify/ProcessHelper.cs

--- SubversionNotify/ProcessHelper.cs    (revision 48)
+++ SubversionNotify/ProcessHelper.cs    (working copy)
@@ -61,6 +61,7 @@
             this.prc.StartInfo.UseShellExecute = false;
             this.prc.StartInfo.RedirectStandardOutput = true;
             this.prc.StartInfo.RedirectStandardError = true;
+            this.prc.StartInfo.StandardOutputEncoding = System.Text.Encoding.Default;
             prc.Start();
             Thread THRoutput = new Thread(new ThreadStart(StdOutReader));
             Thread THRerror = new Thread(new ThreadStart(StdErrorReader));

It's only a line! =)

[mmckechney]

Seiti,
Thank you for the update. I have made the correction and committed the change to the subversion repo.

Mike

[Seiti Yamashiro]

Oh oh, looks like the change broke something. Now I get this on the mail body:

Revision     164
Author     #author#
Date     2008-10-09 16:27:55 -0300 (qui, 09 out 2008)
#logMessage#

The tags #author# and #logMessage# does not work anymore.

[mmckechney]

Seiti,
Yes, while it's hard for me to test, from what I can tell is that the encoding change changes the tokens used in the tool's token replacement method for that feature. I'll have to look in how to make that agnostic to the encoding change too.

Thanks,
Mike