check_email function returned Invalid for Valid e-mail address

[Yusuf TAMBAG]

Hi,

I've recently installed svn-access-manager 0.5.6.6.2 from rpm,
check_email function include/functions.inc.php:345 did not recognized
our internal mail address (yusuft@intra.local) as valid e-mail. So I've
changed this functions content as follows and problem disappeared:

if(!filter_var($email,FILTER_VALIDATE_EMAIL)) {
return false;
} else {
return true;
}

[Yusuf TAMBAG]

Hi,

I've recently installed svn-access-manager 0.5.6.6-2 from rpm. I
realized that when a gruop used more than once with in a repo access
permissions, the users within group is repeated. So I've checked source
code an realized that DISTINCT keyword not used for sql command to
gather group membership in file include/createAuthFiles.php:649 ,
createAccessFilePerRepo method, so I've changed line 649
to

$query = " SELECT
DISTINCT svngroups.groupname, svnusers.userid " .

-thank you very much
-yusuf

[Thomas Krieger]

For the emails thats right. It's not only .local not working. Several new top level domains are currently not working. Thanks for the hint. I fixed the code as you proposed and added tests for all top level domains to see if something is not working in the future.

For the group issue. I can not reproduce it. Can you provide me with an example please to see what to configure to reproduce the issue?