[Sv1-commits] SF.net SVN: sv1: [882] sonic-visualiser/trunk

[<ca...@us...>]

Revision: 882
          http://sv1.svn.sourceforge.net/sv1/?rev=882&view=rev
Author:   cannam
Date:     2007-11-29 09:10:53 -0800 (Thu, 29 Nov 2007)

Log Message:
-----------

* Attempt to fix finding of file:/// URLs
* Fix incorrect reassignment of source model in layers that had no source model
  previously, when replacing a null main model

Modified Paths:
--------------
    sonic-visualiser/trunk/data/fileio/FileFinder.cpp
    sonic-visualiser/trunk/framework/Document.cpp

Modified: sonic-visualiser/trunk/data/fileio/FileFinder.cpp
===================================================================
--- sonic-visualiser/trunk/data/fileio/FileFinder.cpp	2007-11-29 12:02:09 UTC (rev 881)
+++ sonic-visualiser/trunk/data/fileio/FileFinder.cpp	2007-11-29 17:10:53 UTC (rev 882)
@@ -378,15 +378,15 @@
 QString
 FileFinder::find(FileType type, QString location, QString lastKnownLocation)
 {
-    if (QFileInfo(location).exists()) return location;
-
-    if (FileSource::isRemote(location)) {
+    if (FileSource::canHandleScheme(location)) {
         if (FileSource(location).isAvailable()) {
             std::cerr << "FileFinder::find: ok, it's available... returning" << std::endl;
             return location;
         }
     }
 
+    if (QFileInfo(location).exists()) return location;
+
     QString foundAt = "";
 
     if ((foundAt = findRelative(location, lastKnownLocation)) != "") {
@@ -415,6 +415,9 @@
         fileName = QUrl(location).path().section('/', -1, -1,
                                                  QString::SectionSkipEmpty);
     } else {
+        if (QUrl(location).scheme() == "file") {
+            location = QUrl(location).toLocalFile();
+        }
         fileName = QFileInfo(location).fileName();
     }
 
@@ -423,6 +426,9 @@
         if (!FileSource(resolved).isAvailable()) resolved = "";
         std::cerr << "resolved: " << resolved.toStdString() << std::endl;
     } else {
+        if (QUrl(relativeTo).scheme() == "file") {
+            relativeTo = QUrl(relativeTo).toLocalFile();
+        }
         resolved = QFileInfo(relativeTo).dir().filePath(fileName);
         if (!QFileInfo(resolved).exists() ||
             !QFileInfo(resolved).isFile() ||

Modified: sonic-visualiser/trunk/framework/Document.cpp
===================================================================
--- sonic-visualiser/trunk/framework/Document.cpp	2007-11-29 12:02:09 UTC (rev 881)
+++ sonic-visualiser/trunk/framework/Document.cpp	2007-11-29 17:10:53 UTC (rev 882)
@@ -271,7 +271,7 @@
 //                  << (model ? model->objectName().toStdString() : "(null)") << " in layer "
 //                  << layer->objectName().toStdString() << std::endl;
 
-	if (model == oldMainModel) {
+	if (model && (model == oldMainModel)) {
 //            std::cerr << "... it uses the old main model, replacing" << std::endl;
 	    LayerFactory::getInstance()->setModel(layer, m_mainModel);
 	    continue;
@@ -285,7 +285,7 @@
 	    continue;
 	}
 	    
-	if (m_models[model].source == oldMainModel) {
+	if (m_models[model].source && (m_models[model].source == oldMainModel)) {
 
 //            std::cerr << "... it uses a model derived from the old main model, regenerating" << std::endl;
 
@@ -334,7 +334,8 @@
     }
 
     for (ModelMap::iterator i = m_models.begin(); i != m_models.end(); ++i) {
-        if (i->first->getAlignmentReference() == oldMainModel) {
+        if (oldMainModel &&
+            (i->first->getAlignmentReference() == oldMainModel)) {
             alignModel(i->first);
         }
     }


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.