Re: [Sv1-devel] Patches to improve default waveform color

[Chris C. <ca...@al...>]

Hi Jakob -- sorry to take so long replying; as I mentioned privately (I
hope you received it) I was absent for much of the last month and have
had a bit of trouble catching up.

I've taken a look at the three patches and they look generally good --
thank you! There is no standard system of pull requests in place at the
moment; either I could add you as a committer to the main projects (if
you register an account on the code.soundsoftware.ac.uk site) or else I
could pull from another repo hosted elsewhere if you like. I'd be very
happy to see additional branches with code for review and merging, that
would be great.

Just for completeness, some small matters of form about these patches: 

 * please be consistent with other SV code in the spelling of "colour"
 (even though I appreciate it probably isn't your native spelling)
 * in do-not-appy-invalid-color-property.patch, please uses braces for
 the conditional block

Thanks!


Chris

On Sat, Apr 12, 2014, at 07:41 AM, Jakob Leben wrote:
> Hi all,
> 
> I have two patches that, combined, allow the selection of default
> waveform
> color based on view background to take effect, instead of always
> defaulting
> to black-on-white.
> 
> Please see attached files and comment...
> 
> Btw, is there a system of pull-requests in place? I'd be happy to
> collaborate on the main repository. I have created a branch for my
> changes
> in my local repo which I could push, if given permission...
> 
> Best regards,
> Jakob
> ------------------------------------------------------------------------------
> Put Bad Developers to Shame
> Dominate Development with Jenkins Continuous Integration
> Continuously Automate Build, Test & Deployment 
> Start a new project now. Try Jenkins in the cloud.
> http://p.sf.net/sfu/13600_Cloudbees
> _______________________________________________
> Sv1-devel mailing list
> Sv1...@li...
> https://lists.sourceforge.net/lists/listinfo/sv1-devel
> Email had 2 attachments:
> + do-not-apply-invalid-color-property.patch
>   1k (text/x-patch)
> + remove-color-from-default-template.patch
>   2k (text/x-patch)