#282 no full RELRO in piper-vamp-simple-server, sonic-visualiser and vamp-plugin-load-checker

[David Runge]

When building 4.0.1 for Arch Linux I ran our check tool namcap on it. All executables lack full RELRO:

sonic-visualiser W: ELF file ('usr/bin/piper-vamp-simple-server') lacks FULL RELRO, check LDFLAGS.
sonic-visualiser W: ELF file ('usr/bin/sonic-visualiser') lacks FULL RELRO, check LDFLAGS.
sonic-visualiser W: ELF file ('usr/bin/vamp-plugin-load-checker') lacks FULL RELRO, check LDFLAGS.

I was not yet able to figure out where exactly the build system(s) ignore the global LDFLAGS that we export in our package building system ("-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now").

[David Runge]

This basically means: exported $LDFLAGS are completely ignored by the build system.
I've by now tried setting LDFLAGS_RELEASE in configure.ac to my global LDFLAGS, specifically exporting LDFLAGS when calling configure and make and setting QMAKE_LFLAGS to my global LDFLAGS.

None of that works though

[Chris Cannam]

Bug in configure I think. Try this

[David Runge]

@cannam thanks this works! :)