Using -Werror leads to extremely brittle builds and should not be used (especially not in a default build).
I've created a patch (in attachment), that removes this for 4.0.1.
Thanks for the note! I agree, -Werror shouldn't appear in the default release build. It looks as if it was sneaking through from the project files in the checker subrepo. I've updated and committed those so that it is no longer used in the default configuration.
I prefer to keep -Werror in place in debug builds, because it is so useful as to be mandatory within the development cycle. Ideally we would have a third build type to distinguish between "in development" (with -Werror) and "occasional debug build on user site" (without), but that isn't well supported by the Qt or MSVC build tools, and without it, treating debug as the development build type seems to be the best I can do
Therefore I'm not going to remove every occurrence of -Werror, and I'm also not going to mess with those subrepo make/project files that are not used in the SV build. But I am certainly keen to eliminate any places where it accidentally leaks into the release build.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Thanks for the note! I agree,
-Werrorshouldn't appear in the default release build. It looks as if it was sneaking through from the project files in thecheckersubrepo. I've updated and committed those so that it is no longer used in the default configuration.I prefer to keep
-Werrorin place in debug builds, because it is so useful as to be mandatory within the development cycle. Ideally we would have a third build type to distinguish between "in development" (with-Werror) and "occasional debug build on user site" (without), but that isn't well supported by the Qt or MSVC build tools, and without it, treating debug as the development build type seems to be the best I can doTherefore I'm not going to remove every occurrence of
-Werror, and I'm also not going to mess with those subrepo make/project files that are not used in the SV build. But I am certainly keen to eliminate any places where it accidentally leaks into the release build.