#661 Internet plugin test is broken

[Valentin Lorentz]

Hello,

I get this results when testing the Internet plugin :
Testing began at Wed Sep 1 16:13:29 2010 (pid 6387)
testDocumentation (supybot.test.ChannelPluginTestCase) ... ok
testDns (Internet.test.InternetTestCase) ... ok
testDocumentation (Internet.test.InternetTestCase) ... ok
testWhois (Internet.test.InternetTestCase) ... FAIL
testDocumentation (supybot.test.PluginTestCase) ... ok

======================================================================
FAIL: testWhois (Internet.test.InternetTestCase)

---

Traceback (most recent call last):
File "/usr/local/lib/python2.6/dist-packages/supybot/test.py", line 130, in runTest
originalRunTest()
File "plugins/Internet/test.py", line 43, in testWhois
self.assertNotError('internet whois ohio-state.edu')
File "/usr/local/lib/python2.6/dist-packages/supybot/test.py", line 266, in assertNotError
'%r errored: %s' % (query, m.args[1]))
AssertionError: 'internet whois ohio-state.edu' errored: Error: [Errno 111] Connection refused

---

Ran 5 tests in 1.495s

FAILED (failures=1)

Best regards,
ProgVal

[James McCoy]

"Error: [Errno 111] Connection refused" sounds like a network problem between you and whatever edu.whois-servers.net resolved to when you ran the test.

[nanotube]

Well, fwiw, this test always errors for me too, and on different domains, to boot. Like sometimes it would error on ohio-state, other times on microsoft, etc. And with different errors, too. Here's a couple different ones I received from two different runs of 'supybot-test Internet' :

AssertionError: 'internet whois microsoft.com' errored: Error: I couldn't find such a domain.
AssertionError: 'internet whois ohio-state.edu' errored: Error: error: [Errno 104] Connection reset by peer

So if anything, it seems that the problem is with the whois servers being used by the plugin?

[James McCoy]

The plugin uses standard CNAME domains for the specific queries which have various servers in round-robin/load balancing setups. E.g., for ohio-state.edu, it connects to edu.whois-servers.net. For microsoft.com, it connects to com.whois-servers.net.

The "I couldn't find such a domain" is likely a parsing problem in the plugin since whois responses don't follow a standard format. It all depends on what software the server is running.

The "connection reset by peer" problem does seem like it's a problem on the server. Not much we can do about that.