Re: [Superkb-devel] [PATCH] Fix AutoRepeat bug (#432887).

[Octavio A. <alv...@al...>]

On Sun, 05 Dec 2010 01:54:48 -0800, Eduardo A. Bustamante López  
<ebu...@du...> wrote:

> This solves bug described in  
> https://bugs.launchpad.net/superkb/+bug/432887/.

The patch is much, much better. Please include in the commit message  
enough information about *how* you fix the bug. Fixing the bug should be  
seen as a side effect of the patch, and not the other way around.

A good commit short message is "Make sure KeyReleased keys are actually  
not pressed."

For the commit body:

By using XQueryKeymap we make sure the released keys are actually  
released. Otherwise, the KeyRelease event could actually by generated by  
AutoRepeat.

This makes actions not to be launched more than once, which fixes bug  
#XXXXXXXX.

Thank you.

-- 
Octavio.