[Superkb-devel] Superkb bug hunting day, Feb 21st, 2010.

[Octavio A. <alv...@al...>]

Last Sunday (Feb 21st) we had a Superkb bug hunting day.

The participants were:
      * Martin Ibarra
      * Octavio Alvarez

Among other things, Martin was particularly interested in the development
of a GUI configuration tool for Superkb using GTK#/Mono.

So Martin tried to install Superkb and use it in his laptop and we had
some feedback.

== BUGS FOUND ==

-- Bug when Super keys were already grabbed --

Superkb does not start when Super_L or Super_R is being used by another
application. Superkb throws an error.

Mic proposed checking if the Super keys were being used and throw a
notification before launching.

RESOLUTION: The proposed fix by Mic programmatically means to detect if
the grabbing failed and throw a friendly error if so.

Octavio has now committed a patch that implements the error handler for
Xlib to be able to catch the error.

The error is fatal if all configured Super keys fail to be grabbed.

The error is non-fatal more than zero but not all configured Super keys
fail to be grabbed.

In both cases, appropriate recommendations should guide the user on how to
fix the problem.

Please review commits 6142e804d and 6062472

http://superkb.git.sourceforge.net/git/gitweb.cgi?p=superkb/superkb;a=commitdiff;h=6142e804d72f9e3cf776ad8e86e8485fb102afe1
http://superkb.git.sourceforge.net/git/gitweb.cgi?p=superkb/superkb;a=commitdiff;h=6062472ccf1562b8ed64d6df71ae6e825ddff03c

-- AutoRepeat not being restored for Super keys on Ctrl+C --

Reported by Martin Ibarra:

When Superkb is manually configured so gets triggered by a keys other
than Super_L or Super_R, killing Superkb with CTRL+C doesn't restore the
previous Autorepeat property.

This occurred when Superkb was set to use "k".

#Default value:
#  SUPERKEY1_STRING Super_L
SUPERKEY1_STRING k

#Default value:
#  SUPERKEY2_STRING Super_RI
SUPERKEY2_CODE 0

RESOLUTION: This would happen also with Super_L and Super_R.

Two commits were sent, one to properly save the Autorepeat state for the
key and another to handle the SIGINT signal and actually using the saved
values to restore the previous states appropriately before exiting.

Please review commits 1e6616471a and f7b19f0fcd.

http://superkb.git.sourceforge.net/git/gitweb.cgi?p=superkb/superkb;a=commitdiff;h=1e6616471a6993b674b962f3e258aae88d1f2195
http://superkb.git.sourceforge.net/git/gitweb.cgi?p=superkb/superkb;a=commitdiff;h=f7b19f0fcdfc975aaa5b685e6c0a5257cd930352


== REQUESTS FOR ENHANCEMENTS ==

-- Default configuration after 'make install' --

Requested by: Martin Ibarra.

Currently, when installing Superkb using "make install" we don't get a
default configuration. Even though ./sample-config contains some files
that work as examples, it should be considered to use one of those in
/etc/superkbrc or /etc/superkb/superkbrc so it is readily available for
users in the system.

This configuration file should include enough lines so that the user
doesn't get an empty keyboard on first run. The following applications are
proposed:

xterm
gnome-terminal
rxvt
konsole

RESOLUTION: The idea is good. Will try to implement it in the "make
install" part for users that compile Superkb themselves. It will
contain the best possible of the available terminals in some key.

This will be extended to other programs such as a calculator and
a simple text editor.

However, for packages, package maintainers should take care of this
manually when generating packages.

== AGREEMENTS ==

-- Superkb configuration tool interface by Martin Ibarra --

The configuration tool will be run using the following syntax:

$0 key_name shift_state

Example:

superkb-config-tool-martin "l" 0

Parameters will be delimited by spaces.

"shift_state" will be 0 for natural keys and 1 for Shift + key.