Re: [sunxacml-devl] PolicyReader - "optional" Logger

[Lennart J. <li...@rt...>]

Errr... I'll do that (slf4j) - if the others agree...

+1 from me.
 
Am 14.07.2010 um 19:45 schrieb Lennart Jütte:

> I'll do that. But i could take a while (I left my office just after sending my last mail and just got home - so much to do...)
> 
> The patch will be pushed in the next hour or two.
> 
> Cheers,
> Lennart
> 
> Am 14.07.2010 um 18:43 schrieb Farrukh Najmi:
> 
>> 
>> I do not understand why a Logger is being passed as aparm. It is a pattern I have never seen done. Seth?
>> 
>> I would say your deprecation based patch sounds good. 
>> 
>> +1 to commit.
>> 
>> As for supporting other Logging frameworks IMHO slf4j is currently the best alternative to using JDK loggers in a project.
>> 
>> If others agree to slf4j then it would be great if you could replace current Logger code with slf4j as a separate patch from this one.
>> 
>> Thanks Lennart!
>> 
>> On 07/14/2010 10:20 AM, Lennart Jütte wrote:
>>> 
>>> Nice, thank you!
>>> 
>>> i'd say we add a null check in the constructor and create a new logger if required. It's a quick fix that doesn't have any impact on existing code of those using this library.
>>> 
>>> But IMHO it's not very "clever"  to demand a java.utilLogger at all. What about someone who uses another logging Framework? So i would add a new Constructor that doesn't require a logger and set the old ones to @Deprecated. But that's just me, i think...
>>> 
>>> Opinions?
>>> A patch for the second solution is attached.
>>> 
>>> 
>>> 
>>> Am 14.07.2010 um 14:17 schrieb Farrukh Najmi:
>>> 
>>>> Done!. Welcome to the team. Please commit the proposed logger change to conform to prevailing conventions. If any doubts please post patch for review. 
>>>> Also make sure to pull latest changes since we are now on 2.0-M2-SNAPSHOT release in the trunk.
>>>> 
>>>> Thanks.
>>>> 
>>>> On 07/14/2010 07:32 AM, Lennart Jütte wrote:
>>>>> 
>>>>> Hi Farrukh,
>>>>> 
>>>>> my sfid: lajuette
>>>>> 
>>>>> Thanks for adding me!
>>>>> 
>>>>> Cheers,
>>>>> Lennart
>>>>> 
>>>>> Am 14.07.2010 um 13:30 schrieb Farrukh Najmi:
>>>>> 
>>>>>> 
>>>>>> None that I can think of. Seth? BTW, please send me your sfid so I can add you as dev team member so you can make simple fixes like yourself this after discussion on the list. Thanks.
>>>>>> 
>>>>>> On 07/14/2010 05:04 AM, Lennart Jütte wrote:
>>>>>>> 
>>>>>>> The class com.sun.xacml.support.finder contains an instance vairable logger:
>>>>>>> 
>>>>>>>  // the optional logger used for error reporting
>>>>>>>     private Logger logger;
>>>>>>> 
>>>>>>> It has to be set via the constructor. It is not optional at all. Any reason for this?
>>>>>>> 
>>>>>>> 
>>>> 
>>>> -- 
>>>> Regards,
>>>> Farrukh
>>>> 
>>>> Web: http://www.wellfleetsoftware.com
>>>> 
>>>>     
>>> 
>> 
>> 
>> -- 
>> Regards,
>> Farrukh Najmi
>> 
>> Web: http://www.wellfleetsoftware.com
>> 
> 
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by Sprint
> What will you do first with EVO, the first 4G phone?
> Visit sprint.com/first -- http://p.sf.net/sfu/sprint-com-first_______________________________________________
> sunxacml-devl mailing list
> sun...@li...
> https://lists.sourceforge.net/lists/listinfo/sunxacml-devl