[Submount-devel] subfs-0.9 bug with procuid

[Francesc O. <fra...@up...>]

Hi Eugene,

I think I've found a bug in 0.9 version. Say I issue:

mount -t subfs /dev/fd0 /floppy -o fs=floppyfss,procuid,umask=0

Then each time I exec 'ls /floppy' I get:

FAT: Unrecognized mount option "umask=" or missing value

'ls /floppy' again:

FAT: Unrecognized mount option "umask" or missing value

each time subfs.c eats last char from options.

A fix  in subfs.c seems to be:

in mount_real_fs function:
...
    if (sfs_mnt->procuid) {
        len = strlen(sfs_mnt->options);
        if (len == 0)
            len++;
        add_procuid(sfs_mnt->options);
    }
    argv[5] = sfs_mnt->options;
    result = call_usermodehelper(sfs_mnt->helper_prog, argv, envp, 1);
    free_page((unsigned long) path_buf);
    kfree(argv[4]);
    if (sfs_mnt->procuid)
        sfs_mnt->options[len - 1] = '\0';

replace by:

    if (sfs_mnt->procuid) {
        len = strlen(sfs_mnt->options);
        /*if (len == 0)
            len++;*/
        add_procuid(sfs_mnt->options);
    }
    argv[5] = sfs_mnt->options;
    result = call_usermodehelper(sfs_mnt->helper_prog, argv, envp, 1);
    free_page((unsigned long) path_buf);
    kfree(argv[4]);
    if (sfs_mnt->procuid)
        sfs_mnt->options[len /*- 1*/] = '\0';

Please tell me about

Cheers

Francesc Oller