From: Mike F. <va...@ge...> - 2011-12-10 20:54:07
|
Current build fails due to missing stdbool.h include: strace.c:102:1: error: unknown type name 'bool' strace.c: In function 'die_out_of_memory': strace.c:269:2: error: unknown type name 'bool' Signed-off-by: Mike Frysinger <va...@ge...> * strace.c: Include <stdbool.h> --- strace.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/strace.c b/strace.c index 8f8c74c..8e73a00 100644 --- a/strace.c +++ b/strace.c @@ -34,6 +34,7 @@ #include <sys/types.h> #include <stdarg.h> +#include <stdbool.h> #include <signal.h> #include <errno.h> #include <sys/param.h> -- 1.7.6.1 |
From: Dmitry V. L. <ld...@al...> - 2011-12-11 00:08:04
|
On Sat, Dec 10, 2011 at 03:54:00PM -0500, Mike Frysinger wrote: > Current build fails due to missing stdbool.h include: I surely see no build failures on my side, but it depends on system headers. > strace.c:102:1: error: unknown type name 'bool' > strace.c: In function 'die_out_of_memory': > strace.c:269:2: error: unknown type name 'bool' $ git grep -w bool strace.c:static bool daemonized_tracer = 0; strace.c: static bool recursed = 0; I suppose we should rather change them to "int". -- ldv |
From: Dmitry V. L. <ld...@al...> - 2011-12-18 20:14:25
|
On Sat, Dec 10, 2011 at 03:54:00PM -0500, Mike Frysinger wrote: > Current build fails due to missing stdbool.h include: > strace.c:102:1: error: unknown type name 'bool' > strace.c: In function 'die_out_of_memory': > strace.c:269:2: error: unknown type name 'bool' > > Signed-off-by: Mike Frysinger <va...@ge...> > > * strace.c: Include <stdbool.h> Well, this is really odd because stdbool.h is already included via defs.h: $ git grep -i stdbool ChangeLog-CVS: * configure.ac: Add AC_HEADER_STDBOOL. ChangeLog-CVS: * defs.h [HAVE_STDBOOL_H]: #include <stdbool.h>. configure.ac:AC_HEADER_STDBOOL defs.h:#ifdef HAVE_STDBOOL_H defs.h:#include <stdbool.h> I wonder why it doesn't work for you. -- ldv |
From: Mike F. <va...@ge...> - 2011-12-18 20:50:45
Attachments:
signature.asc
|
On Sunday 18 December 2011 15:14:17 Dmitry V. Levin wrote: > On Sat, Dec 10, 2011 at 03:54:00PM -0500, Mike Frysinger wrote: > > Current build fails due to missing stdbool.h include: > > strace.c:102:1: error: unknown type name 'bool' > > strace.c: In function 'die_out_of_memory': > > strace.c:269:2: error: unknown type name 'bool' > > > > Signed-off-by: Mike Frysinger <va...@ge...> > > > > * strace.c: Include <stdbool.h> > > Well, this is really odd because stdbool.h is already included via defs.h: > > $ git grep -i stdbool > ChangeLog-CVS: * configure.ac: Add AC_HEADER_STDBOOL. > ChangeLog-CVS: * defs.h [HAVE_STDBOOL_H]: #include <stdbool.h>. > configure.ac:AC_HEADER_STDBOOL > defs.h:#ifdef HAVE_STDBOOL_H > defs.h:#include <stdbool.h> > > I wonder why it doesn't work for you. good call. i missed that. short answer: drop my proposed patch. seems gcc-4.7 barfs on the configure test code. this would be something to bring up with the autoconf or gcc guys though. configure:5302: checking for stdbool.h that conforms to C99 configure:5387: gcc-4.7.0-alpha20111126 -mx32 -c -O0 -g -ggdb -pipe conftest.c conftest.c:84:3: error: initializer element is not constant and the comment in the conftest.c code specifically calls out known bugs in past gcc :) ... -mike |