From: Frederik S. <fs...@de...> - 2007-09-10 16:20:26
Attachments:
16plus.diff
|
Hello, I updated the debian/rules file to use debhelper applications, and closed another couple of bugs in the packaging. Changelog entry included. Please review the patch, so I can commit it. Best regards Frederik Schüler -- ENOSIG |
From: Frederik S. <fs...@de...> - 2007-09-10 19:29:44
Attachments:
strace-4.5.16-deb.diff
|
Hello, a couple of things slipped through in the first try, but this patch should be it now. Best regards Frederik Schüler -- ENOSIG |
From: Roland M. <ro...@re...> - 2007-09-12 01:16:31
|
It's canonical practice to include your ChangeLog fragment separately before the diffs in the email, rather than as part of the patch. > +2007-08-20 Frederik Schüler <fs...@de...> > + > + * debian/rules: remove manual install calls, use debhelper instead. Also > + use debhelper to build the udeb. This will finally really fix Debian#396682 > + * debian/compat, debian/strace-udeb.install, debian/strace.install, > + debian/strace.manpages: add > + * debian/rules: Add dh_md5sums call, closes Debian#439428 > + * debian/control: Add XC-Package-Type: udeb header to strace-udeb Please clean up the formatting of the log entries a bit to conform to the rest of the file: capitalize sentences; two spaces between sentences; one file per line; "New file." for added files; use "* file (target): " to identify the part of the makefile changed, or the field in debian/control; put "Fixes Debian#nnn." alone on its own line and the end of the paragraph. > + * Reworked deian/rules, more usage of debhelper tools. typo > + * Bumped comapt level to 5 typo Thanks, Roland |
From: Frederik S. <fs...@de...> - 2007-09-13 01:00:13
Attachments:
strace-4.5.16-deb.diff
|
Hello, On Tue, Sep 11, 2007 at 06:16:17PM -0700, Roland McGrath wrote: > It's canonical practice to include your ChangeLog fragment separately > before the diffs in the email, rather than as part of the patch. OK, here it is, cleaned up and adapted, I hope it is fine now: * debian/rules: Remove manual install calls and udeb creation logic, use debhelper tools instead. Fixes Debian#396682. * debian/compat: New file. * debian/strace-udeb.install: New file. * debian/strace.install: New file. * debian/strace.manpages: New file. * debian/rules : Add dh_md5sums call. Fixes Debian#439428. * debian/control (strace-udeb): Add XC-Package-Type: header The attached patch has the two tipos in the Debian changelog fixed, too. Best regards Frederik Sch-- ENOSIG |
From: Frederik S. <fs...@de...> - 2007-10-22 09:01:47
|
Hello Roland, had you any time to look at the patch? It's been 6 weeks now... Best regards Frederik Sch=FCler On Tue, Sep 11, 2007 at 06:16:17PM -0700, Roland McGrath wrote: > Date: Tue, 11 Sep 2007 18:16:17 -0700 (PDT) > From: Roland McGrath <ro...@re...> > To: Frederik Schueler <fs...@de...> > Cc: str...@li... > Subject: Re: Updates to the debian directory > X-Spam-Status: No, score=3D3.3 required=3D4.0 tests=3DFORGED_RCVD_HELO,SP= F_FAIL=20 > autolearn=3Dno version=3D3.1.7-deb >=20 > It's canonical practice to include your ChangeLog fragment separately > before the diffs in the email, rather than as part of the patch. =20 >=20 > > +2007-08-20 Frederik Sch=FCler <fs...@de...> > > + > > + * debian/rules: remove manual install calls, use debhelper instead. A= lso > > + use debhelper to build the udeb. This will finally really fix Debian#= 396682 > > + * debian/compat, debian/strace-udeb.install, debian/strace.install,= =20 > > + debian/strace.manpages: add > > + * debian/rules: Add dh_md5sums call, closes Debian#439428 > > + * debian/control: Add XC-Package-Type: udeb header to strace-udeb >=20 > Please clean up the formatting of the log entries a bit to conform to the > rest of the file: capitalize sentences; two spaces between sentences; one > file per line; "New file." for added files; use "* file (target): " to > identify the part of the makefile changed, or the field in debian/control; > put "Fixes Debian#nnn." alone on its own line and the end of the paragrap= h. >=20 > > + * Reworked deian/rules, more usage of debhelper tools.=20 >=20 > typo >=20 > > + * Bumped comapt level to 5 >=20 > typo >=20 >=20 > Thanks, > Roland --=20 ENOSIG |
From: Roland M. <ro...@re...> - 2007-11-01 20:13:06
|
Sorry for the slow reply. I've been letting all strace mail pile up again. > * debian/rules: Remove manual install calls and udeb creation logic, use > debhelper tools instead. > Fixes Debian#396682. > > * debian/compat: New file. > * debian/strace-udeb.install: New file. > * debian/strace.install: New file. > * debian/strace.manpages: New file. > > * debian/rules : Add dh_md5sums call. > Fixes Debian#439428. > > * debian/control (strace-udeb): Add XC-Package-Type: header The norm is to post the fragment in ChangeLog format, complete with header (C-x 4 a). i.e.: 2007-11-01 Frederik Schueler <fs...@de...> * debian/rules: Remove manual install calls and udeb creation logic, use debhelper tools instead. Fixes Debian#396682. * debian/compat: New file. * debian/strace-udeb.install: New file. * debian/strace.install: New file. * debian/strace.manpages: New file. * debian/rules: Add dh_md5sums call. Fixes Debian#439428. * debian/control (strace-udeb): Add XC-Package-Type: header Also, I have heretofore made ChangeLog entries for all files, including debian/changelog. A trivial entry like, "Update log." is fine, just so the file name and date of change are always listed in ChangeLog. Given correct ChangeLog form, all those changes are fine by me. (I didn't really look into the debian/* magic in detail, I assume you know what's right.) Please go ahead and commit. (In general it's best to do individual commits for each logically separate change, i.e. those that go together into a paragraph in ChangeLog. But it doesn't really matter.) Thanks, Roland |