Re: [PATCH 2/2] Add AArch64 support to strace

[Mike F. <va...@ge...>]

On Tuesday 23 October 2012 12:38:22 Steve McIntyre wrote:
> Add AArch64 support to strace
> 
> AArch64 has been included in Linux from 3.7 onwards. Add support for
> AArch64 in strace, tested on Linux in a simulator.

any plans to support tracing of 32bit arm ELFs ?

> --- /dev/null
> +++ b/linux/aarch64/syscallent.h
>
> +	/* Arch-specific block, not used on AArch64 */
> +	{ MA,	0,	NULL,				"NULL"				}, /*  244 
*/

x32 just does something like:
	[244 ... 259] = { },

can't you do the same ?

> +	/* Blank down to 1023 */

same here:
	[272 ... 1023] = { },

> --- a/syscall.c
> +++ b/syscall.c
>
> +	if (ptrace(PTRACE_GETREGSET, tcp->pid, NT_PRSTATUS, (void *)&io) == -1)
> +	{
> +		return -1;
> +	}

drop the braces
-mike