#3 Patch for failing in making unit test with MingW

5.0
closed-rejected
4
2005-09-16
2005-09-16
heromyth
No

Patches for failing in making unit test with MingW.

Making release-shared and dbg-shared lib tests seems
no problem, failing in stldbg-shared one.

This patch fix it.

Discussion

  • heromyth

    heromyth - 2005-09-16

    Logged In: YES
    user_id=1190746

    Sorry for this repeated patch. I just missed the last patch,
    and I have update STLport from CVS. It seems the patch isn't
    there yet.

     
  • Petr Ovtchenkov

    Petr Ovtchenkov - 2005-09-16
    • labels: --> Build system
    • milestone: --> 519993
    • priority: 5 --> 4
     
  • Petr Ovtchenkov

    Petr Ovtchenkov - 2005-09-16
    • status: open --> open-invalid
     
  • Petr Ovtchenkov

    Petr Ovtchenkov - 2005-09-16

    Logged In: YES
    user_id=615813

    No patch itself attached.

     
  • heromyth

    heromyth - 2005-09-16

    Patch file

     
  • Petr Ovtchenkov

    Petr Ovtchenkov - 2005-09-16

    Logged In: YES
    user_id=615813

    Patch line

    stldbg-shared: DEFS += -D_STLP_USE_DYNAMIC_LIB
    -D_STLP_DEBUG

    is definitly wrong (build/Makefiles/gmake/gcc.mak):

    stldbg-shared : DEFS += -D_STLP_DEBUG

    You should see -D_STLP_DEBUG as option to compiler in compilation
    process.

     
  • Petr Ovtchenkov

    Petr Ovtchenkov - 2005-09-16
    • milestone: 519993 --> 5.0
    • assigned_to: nobody --> complement
     
  • Petr Ovtchenkov

    Petr Ovtchenkov - 2005-09-16

    Logged In: YES
    user_id=615813

    The patch line

    ALL_TAGS := release-shared dbg-shared stldbg-shared

    (i.e. dbg-shared target) is wrong: we don't build -g test in 'all' target to
    save time; it give no additional information (pass/fail) relative
    release-shared and stldbg-shared targets and useful for debugging and
    problem resolution (in this case you may use dbg-shared target
    explicitly).

     
  • Petr Ovtchenkov

    Petr Ovtchenkov - 2005-09-16
    • status: open-invalid --> open-rejected
     
  • Petr Ovtchenkov

    Petr Ovtchenkov - 2005-09-16
    • status: open-rejected --> closed-rejected
     
  • Nobody/Anonymous

    Logged In: NO

    I see. Thank you!

     
  • heromyth

    heromyth - 2005-09-18

    Logged In: YES
    user_id=1190746

    I have used MingW+MSYS. So my osname is cygming.
    That's why I just change this line:
    stldbg-shared: DEFS += -
    D_STLP_USE_DYNAMIC_LIB

    to that:

    stldbg-shared: DEFS += -
    D_STLP_USE_DYNAMIC_LIB -D_STLP_DEBUG

    Here is one of my compilation process lines:

    g++ -Wall -Wsign-promo -fexceptions -fident -mthreads -g -
    D_STLP_NO_CUSTOM_IO -D_STLP_LEAKS_PEDANTIC -
    D_STLP_USE_DYNAMIC_LIB -D_STLP_DEBUG -
    I../../../stlport -c -o obj/gcc/shared-
    stlg/accum_test.o ../../../test/unit/accum_test.cpp

    .

    I have readed www.stlport.com/doc/debug_mode.html again.
    It seems no any problem.

    Although there is no tag 'dbg-shared'. In fact, when I run:
    make -f gcc.mak install
    I have got tree tests:
    shared shared-g shared-stlg
    .

     
  • Petr Ovtchenkov

    Petr Ovtchenkov - 2005-09-18

    Logged In: YES
    user_id=615813

    You made wrong suggestion, I repeat again:

    Patch line

    stldbg-shared: DEFS += -D_STLP_USE_DYNAMIC_LIB
    -D_STLP_DEBUG

    is definitly wrong (build/Makefiles/gmake/gcc.mak):

    stldbg-shared : DEFS += -D_STLP_DEBUG

    You should see -D_STLP_DEBUG as option to compiler in compilation
    process.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks