Re: [Stlport-devel] FstreamTest::offset

[Petr O. <pt...@is...>]

On Sunday 26 August 2007 19:45, François Dumont wrote:
>     What is FstreamTest::offset test for ?

This test is for correct large file support by libstlport, if OS support
large files by some way.

> 
>     Under Win32, 32 bits, streamoff is 8 and off_t is 4 so test fails. 

#if (defined(_LARGEFILE_SOURCE) || defined(_LARGEFILE64_SOURCE)) && !defined(_STLP_USE_DEFAULT_FILE_OFFSET)
  CPPUNIT_CHECK( sizeof(streamoff) == 8 );
#else
  CPPUNIT_CHECK( sizeof(streamoff) == sizeof(off_t) );
#endif

Do you confirm that _LARGEFILE_SOURCE or _LARGEFILE64_SOURCE defined under Wins?

> But what is the point of duplicating an STLport internal configuration 
> in a unit test ?

Again, test that STLport correctly detect OE configuration (but allow
change default support of large files, if somebody want don't use it).
This not totally 'internal' behaviour, because it allow work with
large files or not, and solution coupled with this test allow
forget about problems when, for example, FILE_OFFSET_BITS defined in some
user's headers.

> I am not very interested in doing so. As this  
> configuration is not a problem for STLport, I would prefer to remove 
> this test.
>