Re: [Stlport-devel] exceptions
Brought to you by:
complement
From: Petr O. <pt...@is...> - 2007-05-17 04:33:12
|
I'm sorry for you inconveniences, but take into consideration following notes: - rollback (and apply back) modifications is NORMAL part of development, so I don't see here cause for a screaming match; - you has no plan and target of modifications, so half of you changes are surprise at least for me; chaotic modifications without final goal not impressed me and looks like coding just for coding; WBR, - ptr On Wednesday 16 May 2007 18:10, you wrote: > Hi Petr > > I saw that you rollback above modif for link failure reason. Here is a > link explaining how to submit bug: > > http://stlport.sourceforge.net/BugReport.shtml > > Could you follow your own rules ? I have tested this code under > Windows with MSVC before commiting it. I guess you had problem under > Linux, how do you want me to test it if you do not leave code in SVN. > Are you really expecting SVN trunk to always be ready for a release ? > > > Petr Ovtchenkov wrote: > > + * stlport/stl/_stdexcept_base.h, _stdexcept_base.c: __Names_exception > > + do not truncate anymore exception message when longer than internal > > + static buffer, a dynamic buffer is allocated through malloc in this > > + case. I haven't use __iostring class in this case as it would > > + have introduce a cyclic dependency between classes. > > > > > > +__Named_exception::__Named_exception(const string& __str) { > > + size_t __size = strlen(__get_c_string(__str)) + 1; > > + if (__size > _S_bufsize) { > > + _M_name = (char*)malloc(__size * sizeof(char)); > > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > > > + if (_M_name == 0) { > > + __size = _S_bufsize; > > + _M_name = _M_static_name; > > + } > > + } > > + else { > > + _M_name = _M_static_name; > > + } > > > > > > Well, and what about bad_alloc and exception due to memory limits? > > IMO no dynamic allocation should happen during exception generation. > > > > - ptr > > > > ------------------------------------------------------------------------- > > This SF.net email is sponsored by DB2 Express > > Download DB2 Express C - the FREE version of DB2 express and take > > control of your XML. No limits. Just data. Click to get it now. > > http://sourceforge.net/powerbar/db2/ > > _______________________________________________ > > Stlport-devel mailing list > > Stl...@li... > > https://lists.sourceforge.net/lists/listinfo/stlport-devel > > > > > > > > |