From: Bernhard Reutner-F. <rep...@gm...> - 2010-04-26 17:55:19
|
The first hunk (against stellarium/src/core/external/kdewin32/dirent.c) removes a useless 'if(NULL) free(NULL)' check for the windows port -- and is as such untested but mandated by POSIX. The second hunk does refurbish the Star Catalog download portion of the configuration; Previously there was no hint on - what the catalog contains, magnitude-wise, nor star-count wise - how big a download the catalog was The third hunk adds support for getting the "http_proxy" environment variable that denotes the HTTP-proxy to use in order to access outside world. Without honoring that variable, any download just times out for me (and anyone behind a mandatory proxy (like e.g. squid that i happen to use everywhere) dince direct access is usually and rightfully denied for normal setups (to speed up The Internet-Connection by means of caching). cheers, Bernhard Reutner-Fischer (3): remove useless if() before free() refurbish catalog downloading http_proxy support for networkManager stellarium/src/core/StelApp.cpp | 79 +++++++++ stellarium/src/core/StelApp.hpp | 3 + stellarium/src/core/external/kdewin32/dirent.c | 6 +- stellarium/src/core/modules/StarMgr.cpp | 22 +++- stellarium/src/core/modules/StarMgr.hpp | 2 +- stellarium/src/gui/ConfigurationDialog.cpp | 220 ++++++++++++------------ stellarium/src/gui/ConfigurationDialog.hpp | 16 ++- stellarium/src/gui/configurationDialog.ui | 96 ++++------ 8 files changed, 267 insertions(+), 177 deletions(-) |
From: Bernhard Reutner-F. <rep...@gm...> - 2010-04-26 17:55:12
Attachments:
0002-refurbish-catalog-downloading.patch
|
Signed-off-by: Bernhard Reutner-Fischer <rep...@gm...> --- stellarium/src/core/modules/StarMgr.cpp | 22 +++- stellarium/src/core/modules/StarMgr.hpp | 2 +- stellarium/src/gui/ConfigurationDialog.cpp | 220 ++++++++++++++-------------- stellarium/src/gui/ConfigurationDialog.hpp | 16 ++- stellarium/src/gui/configurationDialog.ui | 96 +++++------- 5 files changed, 182 insertions(+), 174 deletions(-) |
From: Matthew G. <mat...@gm...> - 2010-04-30 13:28:48
|
I'm going to reject this patch because the new list box way of showing what has downloaded doesn't really fit into the dialog. There must be a better way. Perhaps a sub-dialog? I dunno. It's tough to keep everything fitting in the GUI. On 26 April 2010 18:56, Bernhard Reutner-Fischer <rep...@gm...> wrote: > > Signed-off-by: Bernhard Reutner-Fischer <rep...@gm...> > --- > stellarium/src/core/modules/StarMgr.cpp | 22 +++- > stellarium/src/core/modules/StarMgr.hpp | 2 +- > stellarium/src/gui/ConfigurationDialog.cpp | 220 ++++++++++++++-------------- > stellarium/src/gui/ConfigurationDialog.hpp | 16 ++- > stellarium/src/gui/configurationDialog.ui | 96 +++++------- > 5 files changed, 182 insertions(+), 174 deletions(-) > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > > |
From: Bernhard Reutner-F. <rep...@gm...> - 2010-05-03 12:39:19
Attachments:
0001-make-room-in-tools-tab.patch
|
Convert "Object information" to a combo-box and put that and "Program language" into a "General settings" groupBox in the main tab. Move screenshot path selection from "Tools" tab to main tab. Verified that all displays fine on a display that has 600 pixels height. Signed-off-by: Bernhard Reutner-Fischer <rep...@gm...> --- stellarium/src/gui/ConfigurationDialog.cpp | 57 +++--- stellarium/src/gui/ConfigurationDialog.hpp | 4 +- stellarium/src/gui/SkyGui.cpp | 2 + stellarium/src/gui/configurationDialog.ui | 340 +++++++++++++++++----------- 4 files changed, 237 insertions(+), 166 deletions(-) |
From: Bogdan M. <dag...@gm...> - 2010-05-04 08:11:27
|
On Mon, May 3, 2010 at 3:16 PM, Bernhard Reutner-Fischer <rep...@gm...> wrote: > > Convert "Object information" to a combo-box and put that and "Program language" > into a "General settings" groupBox in the main tab. > Move screenshot path selection from "Tools" tab to main tab. > Verified that all displays fine on a display that has 600 pixels height. I almost sent a rather snarky comment. I'll restrain myself to note that there are several problems with the last changes here: http://stellarium.svn.sourceforge.net/viewvc/stellarium?view=rev&revision=6259 I'm working on it at the moment. Bogdan |
From: Matthew G. <mat...@gm...> - 2010-05-04 09:06:04
|
On 4 May 2010 09:11, Bogdan Marinov <dag...@gm...> > I almost sent a rather snarky comment. I'll restrain myself to note > that there are several problems with the last changes here: > http://stellarium.svn.sourceforge.net/viewvc/stellarium?view=rev&revision=6259 > > I'm working on it at the moment. > What's the problem? |
From: Bogdan M. <dag...@gm...> - 2010-05-04 09:28:15
|
On Tue, May 4, 2010 at 12:05 PM, Matthew Gates <mat...@gm...> wrote: > On 4 May 2010 09:11, Bogdan Marinov <dag...@gm...> >> I almost sent a rather snarky comment. I'll restrain myself to note >> that there are several problems with the last changes here: >> http://stellarium.svn.sourceforge.net/viewvc/stellarium?view=rev&revision=6259 >> >> I'm working on it at the moment. >> > > What's the problem? The problems are several, starting from the fact that several elements of the interface are not updated when the program language is changed. I'm fixing this at the moment. Introducing a drop-down list for the object info leads to some complications in the code, which may be unnecessary, but fixing this needs some refactoring, and I am not going to do it. By the way, what should I do with lines 406-415 here? http://stellarium.svn.sourceforge.net/viewvc/stellarium/trunk/stellarium/src/core/modules/StarMgr.cpp?r1=6259&r2=6258&pathrev=6259 Bogdan |
From: Bernhard Reutner-F. <rep...@gm...> - 2010-05-04 10:12:56
|
On Tue, May 04, 2010 at 12:28:08PM +0300, Bogdan Marinov wrote: >By the way, what should I do with lines 406-415 here? >http://stellarium.svn.sourceforge.net/viewvc/stellarium/trunk/stellarium/src/core/modules/StarMgr.cpp?r1=6259&r2=6258&pathrev=6259 I suggest to memset the hipIndex instead of iterating over it. |
From: Fabien C. <fab...@go...> - 2010-05-04 09:53:12
|
Hi, I don't think we should have applied this GUI patch for 0.10.5, we are trying to stabilize now, so focusing on bug fixes. But this patch doesn't fix anything as far as I understand, and like everything new, it will bring new bugs instead. I'll suggest we only accept bug fixes now, and release 0.10.5 as soon as all major bugs are fixed, as there seem to be more and more people waiting for it. Fabien On Tue, May 4, 2010 at 11:28, Bogdan Marinov <dag...@gm...> wrote: > On Tue, May 4, 2010 at 12:05 PM, Matthew Gates <mat...@gm...> wrote: >> On 4 May 2010 09:11, Bogdan Marinov <dag...@gm...> >>> I almost sent a rather snarky comment. I'll restrain myself to note >>> that there are several problems with the last changes here: >>> http://stellarium.svn.sourceforge.net/viewvc/stellarium?view=rev&revision=6259 >>> >>> I'm working on it at the moment. >>> >> >> What's the problem? > > The problems are several, starting from the fact that several elements > of the interface are not updated when the program language is changed. > I'm fixing this at the moment. > > Introducing a drop-down list for the object info leads to some > complications in the code, which may be unnecessary, but fixing this > needs some refactoring, and I am not going to do it. > > By the way, what should I do with lines 406-415 here? > http://stellarium.svn.sourceforge.net/viewvc/stellarium/trunk/stellarium/src/core/modules/StarMgr.cpp?r1=6259&r2=6258&pathrev=6259 > > Bogdan > > ------------------------------------------------------------------------------ > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Bogdan M. <dag...@gm...> - 2010-05-04 10:01:10
|
On Tue, May 4, 2010 at 12:52 PM, Fabien Chéreau <fab...@go...> wrote: > Hi, > I don't think we should have applied this GUI patch for 0.10.5, we are > trying to stabilize now, so focusing on bug fixes. But this patch > doesn't fix anything as far as I understand, and like everything new, > it will bring new bugs instead. > > I'll suggest we only accept bug fixes now, and release 0.10.5 as soon > as all major bugs are fixed, as there seem to be more and more people > waiting for it. I agree. I have just committed two fixes. Feel free to revert both them and Bernard's patch. :) Have a look at the comments & TODOs here: http://stellarium.svn.sourceforge.net/viewvc/stellarium/trunk/stellarium/src/gui/ConfigurationDialog.cpp?r1=6263&r2=6262&pathrev=6263 Regards, Bogdan Marinov |
From: Bernhard Reutner-F. <rep...@gm...> - 2010-05-04 12:40:36
|
On Tue, May 04, 2010 at 01:01:01PM +0300, Bogdan Marinov wrote: >On Tue, May 4, 2010 at 12:52 PM, Fabien Chéreau ><fab...@go...> wrote: >> Hi, >> I don't think we should have applied this GUI patch for 0.10.5, we are >> trying to stabilize now, so focusing on bug fixes. But this patch >> doesn't fix anything as far as I understand, and like everything new, >> it will bring new bugs instead. It doesn't fix anything but it improves the download UI. How can i update the pot files? I tried: me@there:/scratch/obj.i686/stellarium/stellarium$ make update-po-stellarium Scanning dependencies of target generate-pot-stellarium [ 0%] Generating stellarium.pot /bin/sh: -o: command not found make[3]: *** [po/stellarium/CMakeFiles/generate-pot-stellarium] Error 127 make[2]: *** [po/stellarium/CMakeFiles/generate-pot-stellarium.dir/all] Error 2 make[1]: *** [po/stellarium/CMakeFiles/update-po-stellarium.dir/rule] Error 2 make: *** [update-po-stellarium] Error 2 ? >> >> I'll suggest we only accept bug fixes now, and release 0.10.5 as soon >> as all major bugs are fixed, as there seem to be more and more people >> waiting for it. > >I agree. > >I have just committed two fixes. Feel free to revert both them and >Bernard's patch. :) > >Have a look at the comments & TODOs here: >http://stellarium.svn.sourceforge.net/viewvc/stellarium/trunk/stellarium/src/gui/ConfigurationDialog.cpp?r1=6263&r2=6262&pathrev=6263 |
From: Fabien C. <fab...@go...> - 2010-05-19 13:37:41
|
OK, this whole stuff was too nasty to keep for 0.10.5 so i decided to revert it all. At the current state I was not satisfied with it, it introduced problems, the GUI window became too big for small screens, and it also changed too many translatable strings just before the release. We should never have committed that. We can re-work on these additions for version 0.11.0 when we have more time to fix the regressions. Fabien On Tue, May 4, 2010 at 14:17, Bernhard Reutner-Fischer <rep...@gm...> wrote: > On Tue, May 04, 2010 at 01:01:01PM +0300, Bogdan Marinov wrote: >>On Tue, May 4, 2010 at 12:52 PM, Fabien Chéreau >><fab...@go...> wrote: >>> Hi, >>> I don't think we should have applied this GUI patch for 0.10.5, we are >>> trying to stabilize now, so focusing on bug fixes. But this patch >>> doesn't fix anything as far as I understand, and like everything new, >>> it will bring new bugs instead. > > It doesn't fix anything but it improves the download UI. > How can i update the pot files? > I tried: > me@there:/scratch/obj.i686/stellarium/stellarium$ make update-po-stellarium > Scanning dependencies of target generate-pot-stellarium > [ 0%] Generating stellarium.pot > /bin/sh: -o: command not found > make[3]: *** [po/stellarium/CMakeFiles/generate-pot-stellarium] Error 127 > make[2]: *** [po/stellarium/CMakeFiles/generate-pot-stellarium.dir/all] Error 2 > make[1]: *** [po/stellarium/CMakeFiles/update-po-stellarium.dir/rule] Error 2 > make: *** [update-po-stellarium] Error 2 > > ? >>> >>> I'll suggest we only accept bug fixes now, and release 0.10.5 as soon >>> as all major bugs are fixed, as there seem to be more and more people >>> waiting for it. >> >>I agree. >> >>I have just committed two fixes. Feel free to revert both them and >>Bernard's patch. :) >> >>Have a look at the comments & TODOs here: >>http://stellarium.svn.sourceforge.net/viewvc/stellarium/trunk/stellarium/src/gui/ConfigurationDialog.cpp?r1=6263&r2=6262&pathrev=6263 > > ------------------------------------------------------------------------------ > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Bogdan M. <dag...@gm...> - 2010-05-19 13:42:16
|
On Wed, May 19, 2010 at 4:37 PM, Fabien Chéreau <fab...@go...> wrote: > OK, this whole stuff was too nasty to keep for 0.10.5 so i decided to > revert it all. At the current state I was not satisfied with it, it > introduced problems, the GUI window became too big for small screens, > and it also changed too many translatable strings just before the > release. We should never have committed that. > We can re-work on these additions for version 0.11.0 when we have more > time to fix the regressions. Any idea what caused all these "prop[ertie]s changed"? http://stellarium.svn.sourceforge.net/viewvc/stellarium?view=rev&revision=6355 Bogdan |
From: Fabien C. <fab...@go...> - 2010-05-19 13:48:03
|
No, to remove the commits, e.g. 6265 I used the following command (from stellarium/ directory): svn merge -c -6265 . and at commit prompt it mentioned a flag change for all those files.. I have no clues why.. Fabien On Wed, May 19, 2010 at 15:42, Bogdan Marinov <dag...@gm...> wrote: > On Wed, May 19, 2010 at 4:37 PM, Fabien Chéreau > <fab...@go...> wrote: >> OK, this whole stuff was too nasty to keep for 0.10.5 so i decided to >> revert it all. At the current state I was not satisfied with it, it >> introduced problems, the GUI window became too big for small screens, >> and it also changed too many translatable strings just before the >> release. We should never have committed that. >> We can re-work on these additions for version 0.11.0 when we have more >> time to fix the regressions. > > Any idea what caused all these "prop[ertie]s changed"? > http://stellarium.svn.sourceforge.net/viewvc/stellarium?view=rev&revision=6355 > > Bogdan > > ------------------------------------------------------------------------------ > > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Fabien C. <fab...@go...> - 2010-05-19 13:50:09
|
PS: if i removed things which you think should be committed, just tell me. Especially I had conflicts for configurationDialog.ui so I may have suppressed a bit too much. Fabien On Wed, May 19, 2010 at 15:47, Fabien Chéreau <fab...@go...> wrote: > No, to remove the commits, e.g. 6265 I used the following command > (from stellarium/ directory): > svn merge -c -6265 . > and at commit prompt it mentioned a flag change for all those files.. > I have no clues why.. > Fabien > > > On Wed, May 19, 2010 at 15:42, Bogdan Marinov <dag...@gm...> wrote: >> On Wed, May 19, 2010 at 4:37 PM, Fabien Chéreau >> <fab...@go...> wrote: >>> OK, this whole stuff was too nasty to keep for 0.10.5 so i decided to >>> revert it all. At the current state I was not satisfied with it, it >>> introduced problems, the GUI window became too big for small screens, >>> and it also changed too many translatable strings just before the >>> release. We should never have committed that. >>> We can re-work on these additions for version 0.11.0 when we have more >>> time to fix the regressions. >> >> Any idea what caused all these "prop[ertie]s changed"? >> http://stellarium.svn.sourceforge.net/viewvc/stellarium?view=rev&revision=6355 >> >> Bogdan >> >> ------------------------------------------------------------------------------ >> >> _______________________________________________ >> Stellarium-pubdevel mailing list >> Ste...@li... >> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> > |
From: Bernhard Reutner-F. <rep...@gm...> - 2010-04-26 17:55:16
Attachments:
0001-remove-useless-if-before-free.patch
|
Signed-off-by: Bernhard Reutner-Fischer <rep...@gm...> --- stellarium/src/core/external/kdewin32/dirent.c | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) |
From: Bernhard Reutner-F. <rep...@gm...> - 2010-04-26 18:29:42
Attachments:
0003-http_proxy-support-for-networkManager.patch
|
Signed-off-by: Bernhard Reutner-Fischer <rep...@gm...> --- stellarium/src/core/StelApp.cpp | 79 +++++++++++++++++++++++++++++++++++++++ stellarium/src/core/StelApp.hpp | 3 + 2 files changed, 82 insertions(+), 0 deletions(-) |
From: Bogdan M. <dag...@gm...> - 2010-04-26 18:48:28
|
Do I understand correctly that the already existing proxy feature in StelApp doesn't work for you, or you just want to add automatic detection? Also, does the "HTTP_PROXY" environmental variable work on Windows and Mac OS X, too? Regards, Bogdan Marinov |
From: Bogdan M. <dag...@gm...> - 2010-04-29 08:36:00
|
On Mon, Apr 26, 2010 at 9:48 PM, Bogdan Marinov <dag...@gm...> wrote: > [snip] > Also, does the "HTTP_PROXY" environmental variable work on Windows and > Mac OS X, too? Answering my own question: proxy auto-detection for Windows and Mac OS X can be done with QNetworkProxyFactory: http://doc.trolltech.com/4.6/qnetworkproxyfactory.html#setUseSystemConfiguration http://doc.trolltech.com/4.6/qnetworkproxyfactory.html#systemProxyForQuery According to the documentation, "On other systems, there is no standardised method of obtaining the system proxy configuration. This function may be improved in future versions to support those systems." Anyone willing to add this to the code? Also, putting the system-specific code in an #ifdef will be nice. Regards, Bogdan Marinov |
From: Bernhard Reutner-F. <rep...@gm...> - 2010-04-26 20:01:01
|
The http_proxy (note proxy, where would that and user, passwd be handled in current trunk?!) Doesn't work at all, no. The HTTP_PROXY was something ssuggested on the net, no idea who really uses that. Just kept it cowardly. On 26 Apr 2010 20:48, "Bogdan Marinov" <dag...@gm...> wrote: Do I understand correctly that the already existing proxy feature in StelApp doesn't work for you, or you just want to add automatic detection? Also, does the "HTTP_PROXY" environmental variable work on Windows and Mac OS X, too? Regards, Bogdan Marinov ------------------------------------------------------------------------------ _______________________________________________ Stellarium-pubdevel mailing list Ste...@li... https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel |
From: Matthew G. <mat...@gm...> - 2010-04-26 20:15:16
|
Quote a few *nix world tools respect HTTP_PROXY. On 26 April 2010 21:00, Bernhard Reutner-Fischer <rep...@gm...> wrote: > The http_proxy (note proxy, where would that and user, passwd be handled in > current trunk?!) Doesn't work at all, no. > The HTTP_PROXY was something ssuggested on the net, no idea who really uses > that. Just kept it cowardly. > > On 26 Apr 2010 20:48, "Bogdan Marinov" <dag...@gm...> wrote: > > Do I understand correctly that the already existing proxy feature in > StelApp doesn't work for you, or you just want to add automatic > detection? > > Also, does the "HTTP_PROXY" environmental variable work on Windows and > Mac OS X, too? > > Regards, > Bogdan Marinov > > ------------------------------------------------------------------------------ > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > > ------------------------------------------------------------------------------ > > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > > |
From: Bernhard Reutner-F. <rep...@gm...> - 2010-04-26 21:45:30
|
On Mon, Apr 26, 2010 at 09:14:38PM +0100, Matthew Gates wrote: >Quote a few *nix world tools respect HTTP_PROXY. none that i encountered so far, but YMMV. Established standard are http_proxy ftp_proxy no_proxy None of them work with current trunk and QT-4.6.2. And yes, I do consider mis/non handling of those a QT bug for it makes no sense whatsoever if every QT app out there duplicate http_env parsing for proxy setup. Feel free to bug the trolls iff there isn't a bug out there yet which rightfully complains about that missing infrastructure. > >On 26 April 2010 21:00, Bernhard Reutner-Fischer <rep...@gm...> wrote: >> The http_proxy (note proxy, where would that and user, passwd be handled in >> current trunk?!) Doesn't work at all, no. >> The HTTP_PROXY was something ssuggested on the net, no idea who really uses >> that. Just kept it cowardly. >> >> On 26 Apr 2010 20:48, "Bogdan Marinov" <dag...@gm...> wrote: >> >> Do I understand correctly that the already existing proxy feature in >> StelApp doesn't work for you, or you just want to add automatic >> detection? >> >> Also, does the "HTTP_PROXY" environmental variable work on Windows and >> Mac OS X, too? >> >> Regards, >> Bogdan Marinov |
From: Matthew G. <mat...@gm...> - 2010-04-26 22:10:30
|
Ah yes, lower case for curl / lynx. On 26 April 2010 22:47, Bernhard Reutner-Fischer <rep...@gm...> wrote: > On Mon, Apr 26, 2010 at 09:14:38PM +0100, Matthew Gates wrote: >>Quote a few *nix world tools respect HTTP_PROXY. > > none that i encountered so far, but YMMV. Established standard are > http_proxy > ftp_proxy > no_proxy > > None of them work with current trunk and QT-4.6.2. > And yes, I do consider mis/non handling of those a QT bug for it makes > no sense whatsoever if every QT app out there duplicate http_env parsing > for proxy setup. Feel free to bug the trolls iff there isn't a bug out > there yet which rightfully complains about that missing infrastructure. >> >>On 26 April 2010 21:00, Bernhard Reutner-Fischer <rep...@gm...> wrote: >>> The http_proxy (note proxy, where would that and user, passwd be handled in >>> current trunk?!) Doesn't work at all, no. >>> The HTTP_PROXY was something ssuggested on the net, no idea who really uses >>> that. Just kept it cowardly. >>> >>> On 26 Apr 2010 20:48, "Bogdan Marinov" <dag...@gm...> wrote: >>> >>> Do I understand correctly that the already existing proxy feature in >>> StelApp doesn't work for you, or you just want to add automatic >>> detection? >>> >>> Also, does the "HTTP_PROXY" environmental variable work on Windows and >>> Mac OS X, too? >>> >>> Regards, >>> Bogdan Marinov > > ------------------------------------------------------------------------------ > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Matthew G. <mat...@gm...> - 2010-04-28 19:24:12
|
rejected: kdewin32 is an external package, and this is not a security problem - please resubmit upstream. On 26 April 2010 18:56, Bernhard Reutner-Fischer <rep...@gm...> wrote: > > Signed-off-by: Bernhard Reutner-Fischer <rep...@gm...> > --- > stellarium/src/core/external/kdewin32/dirent.c | 6 +++--- > 1 files changed, 3 insertions(+), 3 deletions(-) > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > > |
From: Bogdan M. <dag...@gm...> - 2010-04-29 06:10:27
|
On Wed, Apr 28, 2010 at 10:23 PM, Matthew Gates <mat...@gm...> wrote: > rejected: kdewin32 is an external package, and this is not a security > problem - please resubmit upstream. Matthew, it is possible that it has been fixed upstream - the kdewin32 external hasn't been synchronised with the upstream version for quite some time. Bogdan |