From: Guillaume C. <gui...@gm...> - 2013-09-17 17:09:22
|
(Sorry, I send the email again because I forgot to put a subject. Please don't reply to my previous message.) Hello all! I started to work on an experimental branch to try to get ride of all QAction dependencies in the core of stellarium. This is something that we could eventually merge in the simplegles-qml branch (the Qt5 branch). The rational to remove QAction is that in Qt5 they are not part of QtCore, but QtWidget, and they don't interact well with qml. List of changes (sorry for the long mail): - There is a new class StelAction, that behaves like a qt QAction, with the ability to handle secondary shortcuts. This class replaces the current use of QAction and StelShortcut. - All the StelAction are registered and connected by modules during initialization. This is different from the current code where the actions are first created from the default_shortcut.json file, and then connected to the proper QObject slot during the gui and plugins initialization. - To simplify the code, I added a method of StelModule that creates a new StelAction and automatically connects it to an object slot or property. The interesting thing is that using Qt class introspection, we can directly decide if the action is checkable or not. Plus, when an action is linked to a Qt property that defines a signal handler, the change in the property will automatically change the state of the StelAction. I think this has the potential to fix a few tricky issues with the synchronisation of GUI buttons and module states. - StelAction are identified by the action id only, and not by the group id as it is currently the case. The group id is now only used to sort the actions in the shortcut editor. This makes the code much simpler, the drawback is that we have to ensure that all actions have unique names, but that can be enforced at runtime. - This is not implemented yet, but I am thinking of replacing the json file to store the redefined shortcut, by a much simpler ini file (or even just as a '[shortcuts'] usection in config.ini). It could simply be a list of <action-name> = <new-key-sequence><new-secondary-key-sequence>. - I am also thinking of giving each script a default action name (for example "actionScript/landscapes.ssc"), that way we can also redefine their shortcut shortcuts in the .ini file with the same syntax. I am still working on the branch, but I'd like your input on those changes. This is the branch simplegles-qml-noqaction on launchpad. Best regards, guillaume -- Guillaume gui...@gm... +886 970422910 |
From: Reaves, T. <tr...@si...> - 2013-09-17 23:28:10
|
I'll take a look at your branch. - For the statement " the change in the property will automatically change the state of the StelAction. I think this has the potential to fix a few tricky issues with the synchronisation of GUI buttons and module states." As this is the way QActions work, how would your change be any different in this regard? - As for the manor in which the key binding are stored, JSON may not be ideal, but it is better than 1980's data formats. I understand that some people like what they perceive as the simplisity of a plan text file, but there are down-sides to it as well. JSON is a very widly recognized data format, and unless there is something better that Qt itself likes, I'd stick to the JSON. In this day-and-age, people have no business editing an applications configuration files outside of the application itself; they're just likely to mess them up. On Tue, Sep 17, 2013 at 1:08 PM, Guillaume Chéreau < gui...@gm...> wrote: > (Sorry, I send the email again because I forgot to put a subject. Please > don't reply to my previous message.) > > Hello all! > > I started to work on an experimental branch to try to get ride of all > QAction dependencies in the core of stellarium. This is something that > we could eventually merge in the simplegles-qml branch (the Qt5 branch). > > The rational to remove QAction is that in Qt5 they are not part of > QtCore, but QtWidget, and they don't interact well with qml. > > List of changes (sorry for the long mail): > > - There is a new class StelAction, that behaves like a qt QAction, with > the ability to handle secondary shortcuts. This class replaces the > current use of QAction and StelShortcut. > > - All the StelAction are registered and connected by modules during > initialization. This is different from the current code where the > actions are first created from the default_shortcut.json file, and then > connected to the proper QObject slot during the gui and plugins > initialization. > > - To simplify the code, I added a method of StelModule that creates a new > StelAction and automatically connects it to an object slot or property. > The interesting thing is that using Qt class introspection, we can > directly decide if the action is checkable or not. Plus, when an > action is linked to a Qt property that defines a signal handler, the > change in the property will automatically change the state of the > StelAction. I think this has the potential to fix a few tricky issues > with the synchronisation of GUI buttons and module states. > > - StelAction are identified by the action id only, and not by the group > id as it is currently the case. The group id is now only used to sort > the actions in the shortcut editor. This makes the code much simpler, > the drawback is that we have to ensure that all actions have unique > names, but that can be enforced at runtime. > > - This is not implemented yet, but I am thinking of replacing the json > file to store the redefined shortcut, by a much simpler ini file (or > even just as a '[shortcuts'] usection in config.ini). It could simply > be a list of <action-name> = > <new-key-sequence><new-secondary-key-sequence>. > > - I am also thinking of giving each script a default action name (for > example "actionScript/landscapes.ssc"), that way we can also redefine > their shortcut shortcuts in the .ini file with the same syntax. > > I am still working on the branch, but I'd like your input on those changes. > > This is the branch simplegles-qml-noqaction on launchpad. > > Best regards, > > guillaume > > -- > Guillaume > gui...@gm... > +886 970422910 > > > ------------------------------------------------------------------------------ > LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! > 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, > SharePoint > 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack > includes > Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. > http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |
From: Guillaume C. <gui...@gm...> - 2013-09-18 03:37:39
|
Hi Timothy! Thanks for the comments. On Wed, Sep 18, 2013 at 7:21 AM, Reaves, Timothy <tr...@si...> wrote: > - For the statement " the change in the property will automatically change > the state of the StelAction. I think this has the potential to fix a few > tricky issues with the synchronisation of GUI buttons and module states." As > this is the way QActions work, how would your change be any different in > this regard? With the current code, we need to be careful in the way we connect the QAction to the actual module slots. Usually, what is done is : 1/ set the QAction checked state from the module flag value. 2/ connect the action toggled signal to the proper module slot 3/ If the module defines a notification signal for the value, we connect this to a special method that will set the QAction checked state, only if necessary (cause if we just connect the objects directly we might run into circular connections). If we look, for example, at the way the action "actionShow_Cardinal_Points" is connected to the landscape manager, we have the following steps: (real code in file StelGui.cpp, line 690): 1/ action->setChecked(landscapeMgr->getFlagCardinalsPoints()); 2/ connect(action, toggled(bool), landscapeMgr, setFlagCardinalsPoints(bool)) 3/ connect(landscapeMgr, cardinalsPointsDisplayedChanged, StelGui, cardinalsPointsDisplayedUpdated) and then the StelGui::cardinalsPointsDisplayedUpdated slot is defined like that: if (getGuiAction("actionShow_Atmosphere")->isChecked() != displayed) { getGuiAction("actionShow_Atmosphere")->setChecked(displayed); } I call it tricky in the sense that this is tempting to ignore the step 3, or instead just directly connect the module signal to the action toggle slot, leading to potential bugs. And in fact, currently, many QAction are not updated when the module changes, that is the step 3 is missing for many actions. This means that in many cases, calling a module setSomething(bool) method will not reflect on the associated QAction. In the simplegles-qml-noqaction branch, there is one function to create and connect an action, the last argument being the name of a property or slot. If this is a property, then all the previously explained steps are automatically done, and there is no need to create a separate slot. Also simply adding a NOTIFY handler to an existing module property will make the action aware of external change to it without adding any other line of code. The downside is that I wasn't able to find a way to do it without having to store the QObject and property name in the StelAction. This means we can only link a StelAction to a single object property. > > - As for the manor in which the key binding are stored, JSON may not be > ideal, but it is better than 1980's data formats. I understand that some > people like what they perceive as the simplisity of a plan text file, but > there are down-sides to it as well. JSON is a very widly recognized data > format, and unless there is something better that Qt itself likes, I'd stick > to the JSON. In this day-and-age, people have no business editing an > applications configuration files outside of the application itself; they're > just likely to mess them up. I like JSON too. I was just realizing that since the only data needed to be stored will be a list of key / value, and since we already have config.ini, we could use the same format (or even put the shortcuts into config.ini). If we only save the redefined shortcuts, this might be just a few lines of config data. Of course if we want to keep the possibility to have scripts defined directly in the shortcut config file, then an .ini file would not do. But is there any real use for this? Best regards, guillaume -- Guillaume gui...@gm... +886 970422910 |
From: Alexander W. <ale...@gm...> - 2013-09-18 07:21:38
|
Hello! 2013/9/18 Guillaume Chéreau <gui...@gm...> > Hello all! > > I started to work on an experimental branch to try to get ride of all > QAction dependencies in the core of stellarium. This is something that > we could eventually merge in the simplegles-qml branch (the Qt5 branch). > I'm tried building this branch and catch troubles because StelButton class use C++11 instructions. GCC on my linux only 4.6.3 and him don't known about this standard. Clang 3.4 can't build it by default too. If I add -std=c++11 key then I can compile StelGuiItem but now I have troubles with StelCore because comparison between pointer and integer is wrong. Are you had success building it? -- WBW, Alexander |
From: Bogdan M. <dag...@gm...> - 2013-09-18 09:45:02
|
On Tue, Sep 17, 2013 at 8:08 PM, Guillaume Chéreau < gui...@gm...> wrote: > (Sorry, I send the email again because I forgot to put a subject. Please > don't reply to my previous message.) > > Hello all! > > I started to work on an experimental branch to try to get ride of all > QAction dependencies in the core of stellarium. This is something that > we could eventually merge in the simplegles-qml branch (the Qt5 branch). > > The rational to remove QAction is that in Qt5 they are not part of > QtCore, but QtWidget, and they don't interact well with qml. > > List of changes (sorry for the long mail): > > - There is a new class StelAction, that behaves like a qt QAction, with > the ability to handle secondary shortcuts. This class replaces the > current use of QAction and StelShortcut. > QAction had separate slots and signals for "state changed, by the program or by the user" and "state changed specifically by the user". (See http://qt-project.org/doc/qt-4.8/qaction.html ) Does your code do the same thing? > - All the StelAction are registered and connected by modules during > initialization. This is different from the current code where the > actions are first created from the default_shortcut.json file, and then > connected to the proper QObject slot during the gui and plugins > initialization. > I agree with the "registered by the modules part". For a number of reasons, I dislike the current implementation, but I haven't had the time to do anything about it. See below. - To simplify the code, I added a method of StelModule that creates a new > StelAction and automatically connects it to an object slot or property. > The interesting thing is that using Qt class introspection, we can > directly decide if the action is checkable or not. Plus, when an > action is linked to a Qt property that defines a signal handler, the > change in the property will automatically change the state of the > StelAction. I think this has the potential to fix a few tricky issues > with the synchronisation of GUI buttons and module states. > I agree that such tricky situations are a problem, but I'm not sure if any "automatic" approach won't cause similar problems. I need to look at your code, but I won't be able to run it because of the OpenGL part. :) > - StelAction are identified by the action id only, and not by the group > id as it is currently the case. The group id is now only used to sort > the actions in the shortcut editor. This makes the code much simpler, > the drawback is that we have to ensure that all actions have unique > names, but that can be enforced at runtime. > > - This is not implemented yet, but I am thinking of replacing the json > file to store the redefined shortcut, by a much simpler ini file (or > even just as a '[shortcuts'] usection in config.ini). It could simply > be a list of <action-name> = > <new-key-sequence><new-secondary-key-sequence>. > I like JSON, but I'll leave the dispute about formats to you and Timothy Reaves. :) What I would like is to have only the key sequences that are different from the defaults to be saved to a file. (So there's no default keyboard shortcuts file.) The current system depends too much in keeping strings in sync across multiple files, which is inconvenient and prone to errors. In all cases, I think that the action descriptions shouldn't be kept in the file. By the way, does your code handle dynamic translation of the action descriptions? (I.e. what happens to the descriptions when the language is changed at runtime?) - I am also thinking of giving each script a default action name (for > example "actionScript/landscapes.ssc"), that way we can also redefine > their shortcut shortcuts in the .ini file with the same syntax. > There are a lot of scripts included in the default package. I'm not sure if this won't clutter the key sequence definition window, but this is a relatively minor problem. :) How are you going to handle scripts in subdirectories? Regards, Bogdan Marinov |
From: Guillaume C. <gui...@gm...> - 2013-09-18 11:20:47
|
On Wed, Sep 18, 2013 at 3:21 PM, Alexander Wolf <ale...@gm...> wrote: > I'm tried building this branch and catch troubles because StelButton class > use C++11 instructions. GCC on my linux only 4.6.3 and him don't known about > this standard. Clang 3.4 can't build it by default too. If I add -std=c++11 > key then I can compile StelGuiItem but now I have troubles with StelCore > because comparison between pointer and integer is wrong. Hi Alexander, Can you try again with the current version? I commited a fix that should remove this C++11 hack (I forgot that delegating constructors is not allowed in C++03). gui -- Guillaume gui...@gm... +886 970422910 |
From: Alexander W. <ale...@gm...> - 2013-09-18 11:34:10
|
Hi! 2013/9/18 Guillaume Chéreau <gui...@gm...> > Can you try again with the current version? I commited a fix that > should remove this C++11 hack (I forgot that delegating constructors > is not allowed in C++03). > Now I can build it, thanks! I found other troubles also - some textures for DSO has strange contrast/brightness/color - looks like converting textures into direct GL format is wrong. -- With best regards, Alexander |
From: Barry G. <bar...@ho...> - 2013-09-18 13:00:27
|
Hi Alex Reference the DSO texture display quality. I get this too The two textures I notice particularly are M42 and the horse head. Both pics in my display are my pics. Horse head/flame is reasonable but M42 is badly affected. The most noticeable thing is the intensity/saturation has been increased. I will examine the two textures and see what the difference is. A lot may be due to the amount of stretching done in the original. Barry Date: Wed, 18 Sep 2013 18:34:03 +0700 From: ale...@gm... To: ste...@li... Subject: Re: [Stellarium-pubdevel] Shortcut manager refactorization Hi! 2013/9/18 Guillaume Chéreau <gui...@gm...> Can you try again with the current version? I commited a fix that should remove this C++11 hack (I forgot that delegating constructors is not allowed in C++03). Now I can build it, thanks! I found other troubles also - some textures for DSO has strange contrast/brightness/color - looks like converting textures into direct GL format is wrong. --With best regards, Alexander ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ Stellarium-pubdevel mailing list Ste...@li... https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel |
From: Barry G. <bar...@ho...> - 2013-09-19 04:59:49
|
Build 6281 has fixed the textures for me Barry Date: Wed, 18 Sep 2013 18:34:03 +0700 From: ale...@gm... To: ste...@li... Subject: Re: [Stellarium-pubdevel] Shortcut manager refactorization Hi! 2013/9/18 Guillaume Chéreau <gui...@gm...> Can you try again with the current version? I commited a fix that should remove this C++11 hack (I forgot that delegating constructors is not allowed in C++03). Now I can build it, thanks! I found other troubles also - some textures for DSO has strange contrast/brightness/color - looks like converting textures into direct GL format is wrong. --With best regards, Alexander ------------------------------------------------------------------------------ LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk _______________________________________________ Stellarium-pubdevel mailing list Ste...@li... https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel |
From: Barry G. <bar...@ho...> - 2013-09-18 20:38:31
|
Hi Guillaume I tried your new version but it crashed at the ld.exe stage. The same place that the previuos version failed at before someone made a small change. "bad reloc address 0x20 in section "text$_ZN7QStringD1Ev[__ZN7QSStringD1Ev]" Barry > From: gui...@gm... > Date: Wed, 18 Sep 2013 19:20:18 +0800 > To: ste...@li... > Subject: Re: [Stellarium-pubdevel] Shortcut manager refactorization > > On Wed, Sep 18, 2013 at 3:21 PM, Alexander Wolf <ale...@gm...> wrote: > > I'm tried building this branch and catch troubles because StelButton class > > use C++11 instructions. GCC on my linux only 4.6.3 and him don't known about > > this standard. Clang 3.4 can't build it by default too. If I add -std=c++11 > > key then I can compile StelGuiItem but now I have troubles with StelCore > > because comparison between pointer and integer is wrong. > > Hi Alexander, > Can you try again with the current version? I commited a fix that > should remove this C++11 hack (I forgot that delegating constructors > is not allowed in C++03). > > gui > > -- > Guillaume > gui...@gm... > +886 970422910 > > ------------------------------------------------------------------------------ > LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! > 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint > 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes > Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. > http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel |
From: Guillaume C. <gui...@gm...> - 2013-09-22 15:25:29
|
On Thu, Sep 19, 2013 at 4:38 AM, Barry Gerdes <bar...@ho...> wrote: > I tried your new version but it crashed at the ld.exe stage. The same place > that the previuos version failed at before someone made a small change. "bad > reloc address 0x20 in section "text$_ZN7QStringD1Ev[__ZN7QSStringD1Ev]" Hi! I am going to continue working on the noqaction branch tomorrow. Do you have more info about this problem? What was the commit that previously fixed it? -- Guillaume gui...@gm... +886 970422910 |
From: Barry G. <bar...@ho...> - 2013-09-22 20:25:59
|
Hi Guillaume I have only pulled that branch once and tried a build with Msys. The plugins built and it failed while building the main library . I remember this section failing at the ld.exe on builds some time ago and I think it was fixed quite easily but don't remember how. I am building again at the moment on another computer. I will see if I can be more specific about the error. Here it is I copied it letter by letter I don't think there any typos c:/mingw/bin/../lib/gcc/i686-w64-mingw32/4.8.0/../../../../i686-w64-mingw32/bin/ld.exe:CmakeFiles/stelmaindir/objects.a(stelmainaudioMgr.cpp.obj):bad reloc address 0x20 in section 'text$_ZN7QStringD1Ev[__ZN7QStringD1Ev]' colect2.exe:error ld returned 1 exit Error-1 Barry > From: gui...@gm... > Date: Sun, 22 Sep 2013 23:25:01 +0800 > To: ste...@li... > Subject: Re: [Stellarium-pubdevel] Shortcut manager refactorization > > On Thu, Sep 19, 2013 at 4:38 AM, Barry Gerdes <bar...@ho...> wrote: > > I tried your new version but it crashed at the ld.exe stage. The same place > > that the previuos version failed at before someone made a small change. "bad > > reloc address 0x20 in section "text$_ZN7QStringD1Ev[__ZN7QSStringD1Ev]" > > Hi! I am going to continue working on the noqaction branch tomorrow. > Do you have more info about this problem? What was the commit that > previously fixed it? > > -- > Guillaume > gui...@gm... > +886 970422910 > > ------------------------------------------------------------------------------ > LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! > 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint > 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes > Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/22/13. > http://pubads.g.doubleclick.net/gampad/clk?id=64545871&iu=/4140/ostg.clktrk > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel |
From: Guillaume C. <gui...@gm...> - 2013-09-23 06:54:25
|
On Mon, Sep 23, 2013 at 4:25 AM, Barry Gerdes <bar...@ho...> wrote: > I am building again at the moment on another computer. I will see if I can > be more specific about the error. > Here it is I copied it letter by letter I don't think there any typos > c:/mingw/bin/../lib/gcc/i686-w64-mingw32/4.8.0/../../../../i686-w64-mingw32/bin/ld.exe:CmakeFiles/stelmaindir/objects.a(stelmainaudioMgr.cpp.obj):bad > reloc address 0x20 in section 'text$_ZN7QStringD1Ev[__ZN7QStringD1Ev]' > colect2.exe:error ld returned 1 exit Error-1 I think this might be some of the windows compilation problems that Bogdan fixed in the simplegles-qml branch. I merged it into the noqaction branch. Regards, gui -- Guillaume gui...@gm... +886 970422910 |
From: Barry G. <bar...@ho...> - 2013-09-23 07:18:31
|
Hi Gui The current build of simplegles-qml-noqaction now works after that merge you did Now that I have it running what would you like me to check out. Barry > From: gui...@gm... > Date: Mon, 23 Sep 2013 14:53:57 +0800 > To: ste...@li... > Subject: Re: [Stellarium-pubdevel] Shortcut manager refactorization > > On Mon, Sep 23, 2013 at 4:25 AM, Barry Gerdes <bar...@ho...> wrote: > > I am building again at the moment on another computer. I will see if I can > > be more specific about the error. > > Here it is I copied it letter by letter I don't think there any typos > > c:/mingw/bin/../lib/gcc/i686-w64-mingw32/4.8.0/../../../../i686-w64-mingw32/bin/ld.exe:CmakeFiles/stelmaindir/objects.a(stelmainaudioMgr.cpp.obj):bad > > reloc address 0x20 in section 'text$_ZN7QStringD1Ev[__ZN7QStringD1Ev]' > > colect2.exe:error ld returned 1 exit Error-1 > > I think this might be some of the windows compilation problems that > Bogdan fixed in the simplegles-qml branch. I merged it into the > noqaction branch. > > Regards, > > gui > > > -- > Guillaume > gui...@gm... > +886 970422910 > > ------------------------------------------------------------------------------ > LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! > 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, SharePoint > 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack includes > Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. > http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel |
From: Fabien C. <fab...@gm...> - 2013-09-23 09:09:37
|
Hi, the texture bug was fixed by me in commit 6281<http://bazaar.launchpad.net/~stellarium/stellarium/simplegles-qml/revision/6281> in the simplegles-qml branch. The alpha mode was wrong when rendering the textures. Fabien On Mon, Sep 23, 2013 at 9:18 AM, Barry Gerdes <bar...@ho...>wrote: > Hi Gui > The current build of simplegles-qml-noqaction now works after that merge > you did > Now that I have it running what would you like me to check out. > > Barry > > > From: gui...@gm... > > Date: Mon, 23 Sep 2013 14:53:57 +0800 > > > To: ste...@li... > > Subject: Re: [Stellarium-pubdevel] Shortcut manager refactorization > > > > On Mon, Sep 23, 2013 at 4:25 AM, Barry Gerdes <bar...@ho...> > wrote: > > > I am building again at the moment on another computer. I will see if I > can > > > be more specific about the error. > > > Here it is I copied it letter by letter I don't think there any typos > > > > c:/mingw/bin/../lib/gcc/i686-w64-mingw32/4.8.0/../../../../i686-w64-mingw32/bin/ld.exe:CmakeFiles/stelmaindir/objects.a(stelmainaudioMgr.cpp.obj):bad > > > reloc address 0x20 in section 'text$_ZN7QStringD1Ev[__ZN7QStringD1Ev]' > > > colect2.exe:error ld returned 1 exit Error-1 > > > > I think this might be some of the windows compilation problems that > > Bogdan fixed in the simplegles-qml branch. I merged it into the > > noqaction branch. > > > > Regards, > > > > gui > > > > > > -- > > Guillaume > > gui...@gm... > > +886 970422910 > > > > > ------------------------------------------------------------------------------ > > LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! > > 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, > SharePoint > > 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack > includes > > Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. > > > http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk > > _______________________________________________ > > Stellarium-pubdevel mailing list > > Ste...@li... > > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > > > ------------------------------------------------------------------------------ > LIMITED TIME SALE - Full Year of Microsoft Training For Just $49.99! > 1,500+ hours of tutorials including VisualStudio 2012, Windows 8, > SharePoint > 2013, SQL 2012, MVC 4, more. BEST VALUE: New Multi-Library Power Pack > includes > Mobile, Cloud, Java, and UX Design. Lowest price ever! Ends 9/20/13. > http://pubads.g.doubleclick.net/gampad/clk?id=58041151&iu=/4140/ostg.clktrk > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > > |
From: Guillaume C. <gui...@gm...> - 2013-09-23 10:11:54
|
On Mon, Sep 23, 2013 at 3:18 PM, Barry Gerdes <bar...@ho...> wrote: > Hi Gui > The current build of simplegles-qml-noqaction now works after that merge you > did > Now that I have it running what would you like me to check out. Hi Barry: you can check my last few commits in this branch, it deals with the saving of the shortcuts in the config.ini file. So far I think this is nice like that, because using the global QSettings instance is simple and makes the code small. But there might be some corner cases that I didn't think of. If you want you can also check the StelActionMgr.hpp file. This is more or less a clone of the previous StelShortcutMgr using StelAction instead of QAction. See all the changes I made in the different modules that shows how we register actions. I am quite happy with the automatic connection of actions to slot / properties, but then I understand that we need to be careful with this kind of tricks, so please let me know if you foresee some problems with this approach. I still need to polish the branch before we can even consider merging it ; notably the translation of the action descriptions is probably not working, and also I messed with the group names of the actions, so in the shortcut editor we can see duplicated groups. Regards, gui -- Guillaume gui...@gm... +886 970422910 |
From: Guillaume C. <gui...@gm...> - 2013-09-26 04:07:45
|
Hi all, I think the branch (lp:~stellarium/stellarium/simplegles-qml-noqaction) is ready to be merged into the trunk now. If there are some remaining issues, they can probably be worked on at the same time as the Qt5 branch merge. I plan to merge sometime this week, so let me know if there is something that you think should postpone the merge. Regards, guillaume On Mon, Sep 23, 2013 at 6:11 PM, Guillaume Chéreau <gui...@gm...> wrote: > On Mon, Sep 23, 2013 at 3:18 PM, Barry Gerdes <bar...@ho...> wrote: >> Hi Gui >> The current build of simplegles-qml-noqaction now works after that merge you >> did >> Now that I have it running what would you like me to check out. > > Hi Barry: you can check my last few commits in this branch, it deals > with the saving of the shortcuts in the config.ini file. So far I > think this is nice like that, because using the global QSettings > instance is simple and makes the code small. But there might be some > corner cases that I didn't think of. > > If you want you can also check the StelActionMgr.hpp file. This is > more or less a clone of the previous StelShortcutMgr using StelAction > instead of QAction. See all the changes I made in the different > modules that shows how we register actions. > > I am quite happy with the automatic connection of actions to slot / > properties, but then I understand that we need to be careful with this > kind of tricks, so please let me know if you foresee some problems > with this approach. > > I still need to polish the branch before we can even consider merging > it ; notably the translation of the action descriptions is probably > not working, and also I messed with the group names of the actions, so > in the shortcut editor we can see duplicated groups. > > Regards, > > gui > > -- > Guillaume > gui...@gm... > +886 970422910 -- Guillaume gui...@gm... +886 970422910 |
From: Barry G. <bar...@ho...> - 2013-09-26 05:51:20
|
Hi Gui I have no reason to play with the short cuts but I tried a couple without any problems. The only ones I have used have been with the oculars which is not working yet. The defaults all suit me. There are however some problems in other areas which are also common to the trunk. There is no instruction to build the rendererstatiscs. Has it been permanently dropped. The directions to the location of the nebulae folder has been broken. The search is now to /users/barry/appdata /roaming/stellarium/nebulae/default/nebulae/default instead of /users/barry/appdata /roaming/stellarium/nebulae/default The ocular, telescope and satellite plugins still do not link No start up splash screen, although there is an empty window for a period at the start Barry > From: gui...@gm... > Date: Thu, 26 Sep 2013 12:07:17 +0800 > To: ste...@li... > Subject: Re: [Stellarium-pubdevel] Shortcut manager refactorization > > Hi all, > > I think the branch > (lp:~stellarium/stellarium/simplegles-qml-noqaction) is ready to be > merged into the trunk now. If there are some remaining issues, they > can probably be worked on at the same time as the Qt5 branch merge. I > plan to merge sometime this week, so let me know if there is something > that you think should postpone the merge. > > Regards, > > guillaume > > > On Mon, Sep 23, 2013 at 6:11 PM, Guillaume Chéreau > <gui...@gm...> wrote: > > On Mon, Sep 23, 2013 at 3:18 PM, Barry Gerdes <bar...@ho...> wrote: > >> Hi Gui > >> The current build of simplegles-qml-noqaction now works after that merge you > >> did > >> Now that I have it running what would you like me to check out. > > > > Hi Barry: you can check my last few commits in this branch, it deals > > with the saving of the shortcuts in the config.ini file. So far I > > think this is nice like that, because using the global QSettings > > instance is simple and makes the code small. But there might be some > > corner cases that I didn't think of. > > > > If you want you can also check the StelActionMgr.hpp file. This is > > more or less a clone of the previous StelShortcutMgr using StelAction > > instead of QAction. See all the changes I made in the different > > modules that shows how we register actions. > > > > I am quite happy with the automatic connection of actions to slot / > > properties, but then I understand that we need to be careful with this > > kind of tricks, so please let me know if you foresee some problems > > with this approach. > > > > I still need to polish the branch before we can even consider merging > > it ; notably the translation of the action descriptions is probably > > not working, and also I messed with the group names of the actions, so > > in the shortcut editor we can see duplicated groups. > > > > Regards, > > > > gui > > > > -- > > Guillaume > > gui...@gm... > > +886 970422910 > > > > -- > Guillaume > gui...@gm... > +886 970422910 > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel |
From: Alexander W. <ale...@gm...> - 2013-09-26 05:56:45
|
Hi Barry, 2013/9/26 Barry Gerdes <bar...@ho...> > There are however some problems in other areas which are also common to > the trunk. > There is no instruction to build the rendererstatiscs. Has it been > permanently dropped. > RenderStatistics is deprecated and has been dropped. > The directions to the location of the nebulae folder has been broken. The > search is now to > /users/barry/appdata /roaming/stellarium/nebulae/default/nebulae/default > instead of > /users/barry/appdata /roaming/stellarium/nebulae/default > It should be fixed in trunk of course > > The ocular, telescope and satellite plugins still do not link > I'll try enable their - I believe this issue related to cmake. > No start up splash screen, although there is an empty window for a period > at the start > Splash screen was dropped some time ago. -- With best regards, Alexander |
From: Guillaume C. <gui...@gm...> - 2013-09-26 10:09:00
|
Hi Barry, >> The directions to the location of the nebulae folder has been broken. The >> search is now to >> /users/barry/appdata /roaming/stellarium/nebulae/default/nebulae/default >> instead of >> /users/barry/appdata /roaming/stellarium/nebulae/default Can you try to revert the commit 6195.1.85 ? It might be the problem. guillaume -- Guillaume gui...@gm... +886 970422910 |
From: Barry G. <bar...@ho...> - 2013-09-26 10:38:32
|
Hi gui which commit 6195 is that The last commit for the old stellarium Qt4.8 was 6223 Now 5794 (I think) and this is OK It has only been present since the Qt 5 versions have been in use. I think the first few commits to simplegles-qml (6224,5,6),were OK but I did not rebuild until around 6270 where the problem showed up. The problem is only for the user area. If I remove the nebulae folder from there. The default folder in the main program folder is OK. Barry > From: gui...@gm... > Date: Thu, 26 Sep 2013 18:08:30 +0800 > To: ste...@li... > Subject: Re: [Stellarium-pubdevel] Shortcut manager refactorization > > Hi Barry, > > >> The directions to the location of the nebulae folder has been broken. The > >> search is now to > >> /users/barry/appdata /roaming/stellarium/nebulae/default/nebulae/default > >> instead of > >> /users/barry/appdata /roaming/stellarium/nebulae/default > > Can you try to revert the commit 6195.1.85 ? It might be the problem. > > guillaume > > -- > Guillaume > gui...@gm... > +886 970422910 > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel |
From: Guillaume C. <gui...@gm...> - 2013-09-26 12:30:55
|
On Thu, Sep 26, 2013 at 6:38 PM, Barry Gerdes <bar...@ho...> wrote: > Hi gui > which commit 6195 is that Sorry, the revid is: gui...@gm...-20130917090500-ei4aco0zov3bj468 (set the nebulae image paths relative to the json file) -- Guillaume gui...@gm... +886 970422910 |
From: Barry G. <bar...@ho...> - 2013-09-27 03:21:21
|
Hi Gui I have found the trouble with the non display of my nebulae/default file You have changed the search path for the textures in the textures.json file, shortening it to remove the paths to the textures I think this was done in revision 6280 of the simplegles-qml file I can change my textures.json file but it will then no longer be compatible with the earlier versions Barry > From: gui...@gm... > Date: Thu, 26 Sep 2013 20:30:26 +0800 > To: ste...@li... > Subject: Re: [Stellarium-pubdevel] Shortcut manager refactorization > > On Thu, Sep 26, 2013 at 6:38 PM, Barry Gerdes <bar...@ho...> wrote: > > Hi gui > > which commit 6195 is that > > Sorry, the revid is: > > gui...@gm...-20130917090500-ei4aco0zov3bj468 > > (set the nebulae image paths relative to the json file) > > > -- > Guillaume > gui...@gm... > +886 970422910 > > ------------------------------------------------------------------------------ > October Webinars: Code for Performance > Free Intel webinars can help you accelerate application performance. > Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from > the latest Intel processors and coprocessors. See abstracts and register > > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel |
From: Alexander W. <ale...@gm...> - 2013-09-27 03:24:43
|
Hi Barry, 2013/9/27 Barry Gerdes <bar...@ho...> > > I have found the trouble with the non display of my nebulae/default file > You have changed the search path for the textures in the textures.json > file, shortening it to remove the paths to the textures > I think this was done in revision 6280 of the simplegles-qml file > I can change my textures.json file but it will then no longer be > compatible with the earlier versions > This is acceptable because new series not guarantee backward compatible for formats of files. -- With best regards, Alexander |
From: Barry G. <bar...@ho...> - 2013-09-27 03:46:46
|
Hi Alex I would like to start building in linux again but am having trouble installing Qt5 in my Win 8 virtual drive version. What files are you using. Did you build Qt 5 from source or use the linux version from qt-project.org I also tried this on a virtual Linux under Win 7 where Qt 5.1.1 did install from the linux install file but Stellarium cannot find the Qt5 files. I have run export paths to Qt5 but I still cannot find them. The paths are so long that I may have syntax errors any suggestions By the way now I know why the textures were a no show it is just nuisance value and no longer a problem. Barry Date: Fri, 27 Sep 2013 10:24:35 +0700 From: ale...@gm... To: ste...@li... Subject: Re: [Stellarium-pubdevel] Shortcut manager refactorization Hi Barry, 2013/9/27 Barry Gerdes <bar...@ho...> I have found the trouble with the non display of my nebulae/default file You have changed the search path for the textures in the textures.json file, shortening it to remove the paths to the textures I think this was done in revision 6280 of the simplegles-qml file I can change my textures.json file but it will then no longer be compatible with the earlier versions This is acceptable because new series not guarantee backward compatible for formats of files. -- With best regards, Alexander ------------------------------------------------------------------------------ October Webinars: Code for Performance Free Intel webinars can help you accelerate application performance. Explore tips for MPI, OpenMP, advanced profiling, and more. Get the most from the latest Intel processors and coprocessors. See abstracts and register > http://pubads.g.doubleclick.net/gampad/clk?id=60133471&iu=/4140/ostg.clktrk _______________________________________________ Stellarium-pubdevel mailing list Ste...@li... https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel |