Re: [Stellarium-pubdevel] Satellites plug-in 0.8.0 - testing, code review and merge

[Bogdan M. <dag...@gm...>]

On Thu, Jun 6, 2013 at 11:03 AM, Bogdan Marinov <dag...@gm...> wrote:
> Hello.
>
> In case anyone hasn't noticed, I've proposed my Satellites 0.8.0
> branch for merging, and I'd like people to test and review the
> changes.
>
> If I don't get any feedback before the end of the week, I'll merge it
> anyway - my exams start after the 15th and I'll have to travel to
> Sofia. It's not like it will make the current state of the code any
> worse...

I've merged the branch in the trunk:
http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/6082
http://bazaar.launchpad.net/~stellarium/stellarium/trunk/revision/6083

In the merge request, Alexander Wolf set the review request to
"Approve", but didn't give any other feedback, so I'm not sure what he
had tested. :)

Anyway, there at least one potential bug that I've noticed, related to
custom group names. I remember thinking about it at the time I wrote
the code, but apparently I forgot to implement a solution. Let's see
if someone can find it before I leave for Sofia. :)

Regards,
Bogdan Marinov