From: Fabien C. <fab...@go...> - 2012-02-20 22:52:22
|
Hi guys, I was just followoing the thread from far away. I also don't like much the getFlagNames naming convention, but I never changed it to avoid breaking all code. In Stellarium we have a standard of using getProperyX and setPropertyX for getter and setter. Now if we want to be consistent we should use getXXXDisplayed or getIsXXXDisplayed rather than just isXXXDisplayed. Mmm, well I guess it's not so critical.. In general I am not against making the APIs more consistent, expecially before version 1.0, but we should also take care at not breaking everything if it's really just a matter of taste. On Mon, Feb 20, 2012 at 22:24, Reaves, Timothy <tr...@si...> wrote: > Barry; look up the Second Law of Thermodynamics. To paraphrase: "if it > ain't broke, and you do not continue to fix it, it soon will be broke.' > > I agree with you that the vast majority of the commits over the last year, > maybe even two, have been largely cosmetic. The thing is, that's not likely > to change. Stellarium is stagnate; there is not enough energy going into > the system to prevent bit-rot. That's unfortunate. We simply no longer > have any OpenGL developers. Nor any developers that understand the math > behind a good deal of it. So what does that leave? Small, mainly > non-consequential cosmetic stuff. I disagree, the real working is going in the plugins now, because the core is quite stable. Even if there is much more to do. > The OpenGL state is a real mess. Most of them are attributed to defects in > video drivers. This is not likely to be the case. Other apps, doing far > more sophisticated OpenGL work than Stellarium, do not seem to suffer this. > There are a good deal of driver issues, especially on very low end video > cards. But the OpenGL code simply needs to be cleaned up and fixed. I've > considered posting to some OpenGL forums asking for any interested > developers, but have not come up with a good pitch: "Please fix our code" > probably won't get many respondents. :) The OpenGL state is not so much a mess as you seem to think, but it is a bit complicated for 2 reasons: - we still support old graphic cards which don't support shaders, and using the fixed pipeline is quite different than using the shaders baed one, so maintaining both is by nature no so simple. - we do a lot of non-standard stuff in Stellarium because we handle non linear projections such as Stereographics, or Hammer Aitoff. To make this work with old openGL <= 1.2 drivers requires to do a lot of computation on the CPU instead of GPU. I spent a lot of time trying to abstract this from the higher level code by working on the StelPainter class, and indeed there are not so many places in the code where you actually need to write openGL calls, which is a good sign. At some point we'll need to decide when we stop support for old graphics drivers, and this will able us to move a large part of the rendering pipe line to the GPU. It will be prbably much faster, but I don't expect the code to become much simpler, maybe the opposite. > Start catalogs, and especially DSS objects, could also use a good deal of > love. Both in updating catalogs, and implementation of features. One year ago I did good progress on DSS display, but had no more time working on that since then. There's still a branch where you can display full sky images somewhere, but I probably won't have time in the next months doing anything on Stellarium :( Bye, Fab > Some of the projections are in the same boat. > > Then there is the whole hot-key fiasco. Which is related to the odd way we > handle modules. > > And on-and-on. > > Anyway, for this issue, Matthew & I types on IRC today; he is going to > commit a reversal of the method renaming, while we both work on the > continued property-modification of the code. I'll look into writing a > script tool that can be used to updated scripts. Actually, this could be > done by simply modifying the script engine to output an updated & corrected > version of the script when it is run (that's the way some other tools I use > work). > > > On Mon, Feb 20, 2012 at 3:49 PM, Barry Gerdes <bar...@ho...> > wrote: >> >> Hi All >> >> I agree with Matthew who is also working on the old principal that "if it >> ain't broke why fix it" >> The remarks about Qt are irrelevant and a topic for an argumentative forum >> not this column >> Getting back to current progress. Members have been crying out for the >> release of version 1.0.0 but the last 300 odd cosmetic commits have had >> nothing to do with fixing the core items that are required for the >> release of version 1.0.0. We have some marvelous talent amonst our regular >> programmers. How about turning your talents to fixing the core problems >> associated with the release of version 1.0.0 so we can reach our primary >> goal. >> >> I am not a programmer in the true sense because I don't use C or its >> derivatives but I can still write effective engineering programs in Qbasic >> to solve my requirements. I just regularly compile and test the changes as >> well as possible but do not try every possibility, so i only easily pick up >> the most glaring mistakes. >> >> Barry Gerdes >> Beaumont Hills Observatory >> S 33' 41' 44" E 150' 56' 32" >> >> >> > From: mat...@gm... >> > Date: Mon, 20 Feb 2012 10:28:46 -0800 >> > To: ste...@li... >> > Subject: Re: [Stellarium-pubdevel] renaming of members in the core >> >> > >> > Disambiguation required: >> > >> > QT is an abbreviation for Apple's QuickTime (which Stellarium does not >> > use). >> > >> > QT is also Trolltech/Nokia's QT platform independent SDK, which >> > Stellarium does use. >> > >> > M >> > >> > On 20 February 2012 10:20, Thomas Morris <tom...@gm...> wrote: >> > > I think Timothy was being sarcastic? (Qt is the library/toolkit we >> > > use) >> > > >> > > I tend to agree with Matthew regarding API changes, since many script >> > > engine users may not be regular/serious programmers, and don't want to >> > > change their scripts too often. Just my opinion! >> > > >> > > Thanks, >> > > Thomas >> > > >> > > On 20 February 2012 18:15, Bernhard Reutner-Fischer >> > > <rep...@gm...> wrote: >> > >> On Feb 20, 2012 2:59 PM, "Reaves, Timothy" >> > >> <tr...@si...> >> > >> wrote: >> > >>> >> > >> >> > >>> As an aside, Stellarium does not - and probably never will - use >> > >>> QT. QT >> > >>> is a technology used for playing audio & video. >> > >> >> > >> Did not look at trunk (or however the current SCM calls it) lately >> > >> but IIRC, >> > >> Stellarium _does_ use QT. it does use it to achieve >> > >> platform-independence in >> > >> some areas like path handling (think boost::filesystem, but done >> > >> wrong). >> > >> Furthermore, we implement theme support (think night mode) and >> > >> generally GUI >> > >> elements (think file picker, dialogs in e.g. the configuration dialog >> > >> and >> > >> the other function key bound dialogs, including the buttons in the >> > >> StelBar). >> > >> >> > >> So, while it is true that we do not use QT for rendering nor for >> > >> audio -- >> > >> since we do not do audio (pity BTW goto could use a wooshing sound ;) >> > >> -- we >> > >> do use it to abstract away certain routine tasks. >> > >> >> > >> Just as a sidenote for the curious reader! >> > >> >> > >> Cheers, >> >> > >> >> > >> >> > >> >> > >> ------------------------------------------------------------------------------ >> > >> Try before you buy = See our experts in action! >> > >> The most comprehensive online learning library for Microsoft >> > >> developers >> > >> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, >> > >> MVC3, >> > >> Metro Style Apps, more. Free future releases when you subscribe now! >> > >> http://p.sf.net/sfu/learndevnow-dev2 >> > >> _______________________________________________ >> > >> Stellarium-pubdevel mailing list >> > >> Ste...@li... >> > >> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> > >> >> > > >> > > >> > > ------------------------------------------------------------------------------ >> > > Try before you buy = See our experts in action! >> > > The most comprehensive online learning library for Microsoft >> > > developers >> > > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, >> > > MVC3, >> > > Metro Style Apps, more. Free future releases when you subscribe now! >> > > http://p.sf.net/sfu/learndevnow-dev2 >> > > _______________________________________________ >> > > Stellarium-pubdevel mailing list >> > > Ste...@li... >> > > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> > >> > >> > ------------------------------------------------------------------------------ >> > Try before you buy = See our experts in action! >> > The most comprehensive online learning library for Microsoft developers >> > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, >> > Metro Style Apps, more. Free future releases when you subscribe now! >> > http://p.sf.net/sfu/learndevnow-dev2 >> > _______________________________________________ >> > Stellarium-pubdevel mailing list >> > Ste...@li... >> > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> >> >> ------------------------------------------------------------------------------ >> Try before you buy = See our experts in action! >> The most comprehensive online learning library for Microsoft developers >> is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, >> Metro Style Apps, more. Free future releases when you subscribe now! >> http://p.sf.net/sfu/learndevnow-dev2 >> _______________________________________________ >> Stellarium-pubdevel mailing list >> Ste...@li... >> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel >> > > > ------------------------------------------------------------------------------ > Try before you buy = See our experts in action! > The most comprehensive online learning library for Microsoft developers > is just $99.99! Visual Studio, SharePoint, SQL - plus HTML5, CSS3, MVC3, > Metro Style Apps, more. Free future releases when you subscribe now! > http://p.sf.net/sfu/learndevnow-dev2 > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |