From: Johannes G. <joh...@gm...> - 2007-07-02 20:51:54
|
Dear Fabien and developers, I admit that the last months since version 0.8.2 I did not spend much time in commenting the code. Sorry. Especially after release of 0.9 I did nearly no commenting at all, but instead lost lots of time arguing with dissatisfied users, promising configuration options and implementing them. I am kind of sad that the new star feature seems to be displeasing to so many users, although I like it so much. I also thought that Fabien would implement something for adjusting of the tone reproductor to the brightest object on screen - at least in my memory this was planned in Garching for version 0.9. And well, so are still things to do 1) adjust to the brightest object on screen / in FOV 2) mmap for bigendian 3) optionally reintroduce the sqrt-bug for brightness exaggeration, so that it becomes obvious to everybody what chaos it gives 4) code reorganisation (different files, comments,...) In any case I cannot do this now, because my left hand hurts and my fingers are without feeling and kind of lame, which is annoying while typing. So if you expect big changes from me, you will have to wait. I considered to offer removal of my star code and to reintroduce the stuff from 0.8.2. But because of the changes with StelObject and the smart pointers, this is not so straight forward, and I think it is easier to do another step forward by implementing the sqrt-bug as an optional feature. By enabling it you would get pretty much the same star sizes as in 0.8.2 for Hipparcos stars. For fainter stars it would not work out of course. Colors are already user configurable. Johannes On 2007.06.30 01:59:32 MEST, Fabien Chéreau wrote: > Johannes, > > I beg you to considere commenting your code, you have to understand that the > code that you write will be read by others. > The coding convention defined on the wiki have to be respected, and from all > of them, code commenting is the most important. > > Thanks. > > Fabien |