From: F. C. <fab...@go...> - 2008-03-18 13:47:52
|
Hi Nigel, I comited your patch :) You should now start again to work from the SVN version. So the patch is good, there are however some minor problems: - when I run the soft, I get a lot of warning/debug print on the console. Could you avoid that? - for the new time widget it looks very promising, the validator is nice, you should also add some up/down arrows like in QDateTime widgets, but I guess it was already planned :) Thanks a lot! Fabien On Mon, Mar 17, 2008 at 1:55 PM, Nigel Kerr <nig...@gm...> wrote: > I'll see what i can do this evening! > > cheers, > nigel > > > > On Mon, Mar 17, 2008 at 4:42 AM, Fabien Chéreau > <fab...@go...> wrote: > > Hi Nigel, > > Thank for the patch! It looks promisin. However could you please clean your > > patch? 80% of it's content are just suppressing tabs and space... It is > > important that patches contain the minimum modifications otherwise it takes > > ages to check.. > > Cheers, > > Fabien > > > > > > > > > > On Sun, Mar 16, 2008 at 9:09 PM, Nigel Kerr <nig...@gm...> wrote: > > > > > > > > > > > > good folk, > > > > > > I just submitted > > > > > http://sourceforge.net/tracker/index.php?func=detail&aid=1915675&group_id=48857&atid=454375 > > > , I would appreciate it if a committer could let me know when or if it > > > can be applied. See the patch description for more gorey details. > > > > > > In particular, though, I'd note that > > > > > > 1. CTest now enabled via this patch: a test target is added, and all > > > tests added are run. "tests" are just executables, that exit with > > > non-zero on any failure. There is one test there now, a somewhat > > > primitive test versus my date/time functions. This has been useful to > > > me in getting things correct, and any sort of non-gui computation > > > could probably benefit from such automated tests of normal and > > > boundary conditions. (However: having just pressed the submit button, > > > i realize the test i've got for whether Qt understands EST/EDT time > > > won't work in any other timezone...argh...). > > > > > > 2. timezone detection works on the following principles: > > > a. we don't care what the name of the local timezone is, just the GMT > > offset > > > b. we let Qt figure all that out, we rely on QDateTime's .toUTC() to > > > provide the offset. > > > c. (as a consequence of b) if Qt doesn't know details about the shift > > > for a point in the past or future, we fall back to shift at the > > > present. > > > > > > I've seen the code in question for #2 work on a mac and a windows xp > > > machine with Qt 4.3.4: selecting various dates in the last year, I can > > > get reliably the right offset-from-GMT. > > > > > > i'm pretty sure the date-time dialog box isn't in its final > > > appearance, but it is serviceable now. > > > > > > cheers, > > > Nigel > > > > > > ------------------------------------------------------------------------- > > > This SF.net email is sponsored by: Microsoft > > > Defy all challenges. Microsoft(R) Visual Studio 2008. > > > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > > > _______________________________________________ > > > Stellarium-pubdevel mailing list > > > Ste...@li... > > > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > > > > > > > > > ------------------------------------------------------------------------- > > This SF.net email is sponsored by: Microsoft > > Defy all challenges. Microsoft(R) Visual Studio 2008. > > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > > _______________________________________________ > > Stellarium-pubdevel mailing list > > Ste...@li... > > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > > > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Microsoft > Defy all challenges. Microsoft(R) Visual Studio 2008. > http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ > _______________________________________________ > Stellarium-pubdevel mailing list > Ste...@li... > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel > |