Hi Matthew
I can confirm that under Windows. I tried to build 4885 with the patch and it bombed out also. 4885 built OK as standard.
 
Barry


Barry Gerdes
Beaumont Hills Observatory
S 33' 41' 44"    E 150' 56' 32"
12" F10 GPS Polar mounted
Home Page  http://www.geocities.com/barrykgerdes
 



 
> Date: Mon, 17 Aug 2009 20:15:15 +0100
> From: matthewg42@gmail.com
> To: stellarium-pubdevel@lists.sourceforge.net
> Subject: Re: [Stellarium-pubdevel] SunEclipse patch for better rendering a solar eclipse
>
> Hi
> Andreas,
>
> I saw the patch and the effect is very nice. However, I am concerned
> about the addition of a Planet parameter to the
> StelSkyDrawer::postDrawSky3dModel. I know Fabien spend a lot of time
> to clean these drawing functions and separate out object specific
> stuff. I didnt try to understand this code, or your patch, so I can't
> say if it's necessary or possible to do it another way - I would
> rather Fabien takes a look at it and makes a suggestion as he knows
> this code so well.
>
> Less importantly,and probably easily fixable, I also get build errors
> against revision 4885:
>
> [ 3%] Building CXX object
> src/CMakeFiles/stellarium.dir/core/StelSkyDrawer.cpp.o
> In file included from /usr/include/qt4/QtCore/qmetatype.h:49,
> from /usr/include/qt4/QtCore/qvariant.h:48,
> from /usr/include/qt4/QtCore/QVariant:1,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSphereGeometry.hpp:24,
> from
> /home/matthew/stellarium/stellarium/src/core/StelRegionObject.hpp:23,
> from
> /home/matthew/stellarium/stellarium/src/core/StelObject.hpp:26,
> from
> /home/matthew/stellarium/stellarium/src/modules/Planet.hpp:25,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSkyDrawer.hpp:27,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSkyDrawer.cpp:20:
> /usr/include/qt4/QtCore/qdatastream.h:49:2: error: #error
> qdatastream.h must be included before any header file that defines
> Status
> In file included from /usr/include/qt4/QtCore/qvariant.h:48,
> from /usr/include/qt4/QtCore/QVariant:1,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSphereGeometry.hpp:24,
> from
> /home/matthew/stellarium/stellarium/src/core/StelRegionObject.hpp:23,
> from
> /home/matthew/stellarium/stellarium/src/core/StelObject.hpp:26,
> from
> /home/matthew/stellarium/stellarium/src/modules/Planet.hpp:25,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSkyDrawer.hpp:27,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSkyDrawer.cpp:20:
> /usr/include/qt4/QtCore/qmetatype.h:53:2: error: #error qmetatype.h
> must be included before any header file that defines Bool
> In file included from /usr/include/qt4/QtCore/qdebug.h:50,
> from /usr/include/qt4/QtCore/QDebug:1,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSphereGeometry.hpp:25,
> from
> /home/matthew/stellarium/stellarium/src/core/StelRegionObject.hpp:23,
> from
> /home/matthew/stellarium/stellarium/src/core/StelObject.hpp:26,
> from
> /home/matthew/stellarium/stellarium/src/modules/Planet.hpp:25,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSkyDrawer.hpp:27,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSkyDrawer.cpp:20:
> /usr/include/qt4/QtCore/qtextstream.h:59:2: error: #error
> qtextstream.h must be included before any header file that defines
> Status
> In file included from /usr/include/qt4/QtCore/qmetatype.h:49,
> from /usr/include/qt4/QtCore/qvariant.h:48,
> from /usr/include/qt4/QtCore/QVariant:1,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSphereGeometry.hpp:24,
> from
> /home/matthew/stellarium/stellarium/src/core/StelRegionObject.hpp:23,
> from
> /home/matthew/stellarium/stellarium/src/core/StelObject.hpp:26,
> from
> /home/matthew/stellarium/stellarium/src/modules/Planet.hpp:25,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSkyDrawer.hpp:27,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSkyDrawer.cpp:20:
> /usr/include/qt4/QtCore/qdatastream.h:98: error: expected identifier
> before ‘int’
> /usr/include/qt4/QtCore/qdatastream.h:98: error: expected
> unqualified-id before ‘{’ token
> /usr/include/qt4/QtCore/qdatastream.h: In function ‘QDataStream&
> operator>>(QDataStream&, QHash<Key, T>&)’:
> /usr/include/qt4/QtCore/qdatastream.h:338: error: expected
> unqualified-id before ‘int’
> /usr/include/qt4/QtCore/qdatastream.h:338: error: expected `;' before ‘int’
> /usr/include/qt4/QtCore/qdatastream.h:346: error: ‘Ok’ is not a member
> of ‘QDataStream’
> /usr/include/qt4/QtCore/qdatastream.h:355: error: ‘Ok’ is not a member
> of ‘QDataStream’
> /usr/include/qt4/QtCore/qdatastream.h:357: error: ‘oldStatus’ was not
> declared in this scope
> /usr/include/qt4/QtCore/qdatastream.h:357: error: ‘Ok’ is not a member
> of ‘QDataStream’
> /usr/include/qt4/QtCore/qdatastream.h: In function ‘QDataStream&
> operator>>(QDataStream&, QMap<aKey, aT>&)’:
> /usr/include/qt4/QtCore/qdatastream.h:382: error: expected
> unqualified-id before ‘int’
> /usr/include/qt4/QtCore/qdatastream.h:382: error: expected `;' before ‘int’
> /usr/include/qt4/QtCore/qdatastream.h:392: error: ‘Ok’ is not a member
> of ‘QDataStream’
> /usr/include/qt4/QtCore/qdatastream.h:401: error: ‘Ok’ is not a member
> of ‘QDataStream’
> /usr/include/qt4/QtCore/qdatastream.h:403: error: ‘oldStatus’ was not
> declared in this scope
> /usr/include/qt4/QtCore/qdatastream.h:403: error: ‘Ok’ is not a member
> of ‘QDataStream’
> In file included from /usr/include/qt4/QtCore/qvariant.h:48,
> from /usr/include/qt4/QtCore/QVariant:1,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSphereGeometry.hpp:24,
> from
> /home/matthew/stellarium/stellarium/src/core/StelRegionObject.hpp:23,
> from
> /home/matthew/stellarium/stellarium/src/core/StelObject.hpp:26,
> from
> /home/matthew/stellarium/stellarium/src/modules/Planet.hpp:25,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSkyDrawer.hpp:27,
> from
> /home/matthew/stellarium/stellarium/src/core/StelSkyDrawer.cpp:20:
> /usr/include/qt4/QtCore/qmetatype.h: At global scope:
> /usr/include/qt4/QtCore/qmetatype.h:66: error: expected identifier before ‘int’
> /usr/include/qt4/QtCore/qmetatype.h:66: error: expected `}' before ‘int’
> /usr/include/qt4/QtCore/qmetatype.h:66: error: expected unqualified-id
> before ‘=’ token
> /usr/include/qt4/QtCore/qmetatype.h:114: error: expected declaration
> before ‘}’ token
> /usr/include/qt4/QtCore/qmetatype.h:99: warning: ‘void
> registerStreamOperators(const char*, void (*)(QDataStream&, const
> void*), void (*)(QDataStream&, void*))’ declared ‘static’ but never
> defined
> /usr/include/qt4/QtCore/qmetatype.h:102: warning: ‘int
> registerType(const char*, void (*)(void*), void* (*)(const void*))’
> declared ‘static’ but never defined
> /usr/include/qt4/QtCore/qmetatype.h:103: warning: ‘int type(const
> char*)’ declared ‘static’ but never defined
> /usr/include/qt4/QtCore/qmetatype.h:104: warning: ‘const char*
> typeName(int)’ declared ‘static’ but never defined
> /usr/include/qt4/QtCore/qmetatype.h:105: warning: ‘bool
> isRegistered(int)’ declared ‘static’ but never defined
> /usr/include/qt4/QtCore/qmetatype.h:106: warning: ‘void*
> construct(int, const void*)’ declared ‘static’ but never defined
> /usr/include/qt4/QtCore/qmetatype.h:107: warning: ‘void destroy(int,
> void*)’ declared ‘static’ but never defined
> /usr/include/qt4/QtCore/qmetatype.h:108: warning: ‘void
> unregisterType(const char*)’ declared ‘static’ but never defined
> /usr/include/qt4/QtCore/qmetatype.h:111: warning: ‘bool
> save(QDataStream&, int, const void*)’ declared ‘static’ but never
> defined
> /usr/include/qt4/QtCore/qmetatype.h:112: warning: ‘bool
> load(QDataStream&, int, void*)’ declared ‘static’ but never defined
> make[2]: *** [src/CMakeFiles/stellarium.dir/core/StelSkyDrawer.cpp.o] Error 1
> make[1]: *** [src/CMakeFiles/stellarium.dir/all] Error 2
> make: *** [all] Error 2
>
>
> 2009/8/11 Andreas Bormann <bormann.gm@googlemail.com>:
> > Hello all,
> >
> > this is my first post to the Stellarium pubdevel list.
> >
> > Coincidentally with the tenth anniversary of the 1999 total eclipse I'd like
> > to submit my SunEclipse patch. It fixes the appearance of the corona and
> > implements a moving glare as halo.
> >
> > You can view a rendering of the 1999 eclipse on this page:
> >
> >     http://www.7x8.de/SunEclipse-Patch.html
> >
> > If you like you can download a modified libstelMain_dll for Stellarium
> > 0.10.2 to test the patch with the current version of Stellarium.
> >
> > - To submit the patch will I have to post it on this list or upload it on
> > SourceForge? (Do I need an account there?)
> >
> > Greetings
> > Andreas
> >
> > ------------------------------------------------------------------------------
> > Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> > trial. Simplify your report design, integration and deployment - and focus
> > on
> > what you do best, core application coding. Discover what's new with
> > Crystal Reports now.  http://p.sf.net/sfu/bobj-july
> > _______________________________________________
> > Stellarium-pubdevel mailing list
> > Stellarium-pubdevel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel
> >
> >
>
> ------------------------------------------------------------------------------
> Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
> trial. Simplify your report design, integration and deployment - and focus on
> what you do best, core application coding. Discover what's new with
> Crystal Reports now. http://p.sf.net/sfu/bobj-july
> _______________________________________________
> Stellarium-pubdevel mailing list
> Stellarium-pubdevel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/stellarium-pubdevel


Check the daily blob for the latest on what's happening around the web What goes online, stays online