Menu

#96 bad encoding of viewvc link

open
nobody
5
2009-05-27
2009-05-27
No

using the -viewvc option, the url passed via the cli is taken as relative and then urlencoded in the output, even though is starts with http.

ex: using -viewvc http://pubsvn.ez.no/viewvc/nextgen/trunk/kernel the resulting link's href is

http://pubsvn.ez.no/statsvn/trunk/http%3A%2F%2Fpubsvn.ez.no%2Fviewvc%2Fnextgen%2Ftrunk%2Fkernel%2Fcommon%2Feztemplatedesignresource.php%3Fr1%3D23095%26amp%3Br2%3D23612

Discussion

  • ajayesh

    ajayesh - 2009-12-18

    Hi Gaetano,

    I was just checking the online demos for StatSVN and in the following the URL encoding problem has been solved:

    ObjectLAB
    AntUnit
    XStream
    Ant-SVN
    Jtreemap
    QALab
    Ant
    Ruby
    Joda Time

    You need to ask these teams what switches and commands these guys used to fix the URL encoding issue with ViewVC. All other demos seem to be suffering from the same URL problems.

    Thanks and kind regards,
    Ajayesh Srinivasan

     
  • ajayesh

    ajayesh - 2009-12-18

    Almost forgot to add this. Even if these demos did a workaround, I'd definitely be interested in knowing how these guys did it.

    Thanks again,
    Ajayesh

     
  • ajayesh

    ajayesh - 2009-12-18

    Just checked this issue doesn't exist with 0.4.1. Maybe it got introduced at a later stage.

     
  • Jason Kealey

    Jason Kealey - 2009-12-21

    Simply put, some people have been complaining about international characters not being rendered properly in our tool w/ regards to ViewVC and our fix for that issue may have broken the URL rendering scheme after 0.4.1. Simply put, we need someone who is running a ViewVC installation to help us with this issue. The resolution is probably simple, but will require debugging to ensure that the script still works if you give statsvn an absolute URL, a relative url that is at the root of the repository, and a relative url that isn't at the root of the repository.

    Thanks!

     
  • ajayesh

    ajayesh - 2009-12-21

    Hi Jason,

    I'd like to volunteer. Send the details across as to what needs to be done for v0.5 and I'll try the fix for absolute URL encodes. I've got a ViewVC working as well as StatSVN deployed on the system.

    I did roll-back to v0.4.1 after the URL encode bug but would take a crack at v0.5 if you send across the relevant details.

    Thanks and regards,
    Ajayesh

     
  • ajayesh

    ajayesh - 2009-12-21

    By the way, the reason I want v0.5 to be fixed is it is way to cool and the interface is much more polished than v0.4.1.

     
  • Jason Kealey

    Jason Kealey - 2009-12-22

    You'll probably need to checkout both StatCVS and StatSVN's source code off of sourceforge.

    statcvs\src\net\sf\statcvs\output\View*Integration.java are the files you should be looking at.

    Thanks!

     

Log in to post a comment.