|
From: Wesley W. T. <we...@te...> - 2002-01-30 02:56:25
|
On Tue, Jan 29, 2002 at 06:37:03PM -0800, Gene Shekhtman wrote: > I wonder if DARWIN can be combined with OPENBSD in md.h. > Something like that: > > #elif defined (OPENBSD) || defined (DARWIN) > > .... > > #if defined(__i386__) > #define MD_JB_SP 2 > #elif defined(__alpha__) > #define MD_JB_SP 34 > #elif defined(__ppc__) > #define MD_JB_SP 0 > #else > #error Unknown CPU architecture > #endif > > Unfortunately, I don't have OpenBSD on PPC to test it. I tried exactly that when I first made the patch - it does work. However, there is a few reasons I choose not to do that: -- What if OpenBSD runs on a ppc at some point? This will probably mess up - 0 will not be right. Just look at AIX; it uses 3 for the same CPU. -- Conversely, Darwin already does run on i386. I have no idea what MD_JP_SP to use there though. However, I doubt it's safe to assume it's 2. On the other hand, if someone who runs darwin/i386 tries it and finds that the value is 2, then merging them is probably smart. PS. The thing that really annoys me is the poll.h problem. (!!) -- Wesley W. Terpstra <we...@te...> |