Re: [Statcvs-users] [PATCH] Make the author page display real names (if available)

[Richard C. <ri...@cy...>]

Hi James,

Thanks for the patches. I think that adding external author metadata  
(real names, but also email addresses and a link to a web page) is a  
useful addition. But I don't like the way you've architected it.  
Other users may want to get author data from other sources than  
passwd files, and your patch would make it a bit hard to add other  
sources.

I'd suggest you change the patch to keep the passwd-specific logic  
out of the core classes. Some ideas for this:

- Store the real names not in the Author instances, but in a new  
class, say PasswdFile, with a getRealName(Author) method.
- make PasswdFile an implementation of a new interface, say  
AuthorProfilesIntegration, which has just that method for the moment.

This is the same general approach as with File and  
WebRepositoryIntegration. Please have a look at how these classes are  
used for inspiration. Note that we have a couple of different  
WebRepositoryIntegration implementations, and adding new ones is  
easy. I'd like to have the same possiblity for external author data.

Steffen, any insight on this? What would be a good way to support  
both Maven and passwd files as data sources?

Cheers,
Richard


On 27 Nov 2005, at 02:35, James Ring wrote:

> Hi all,
>
> This patch makes the author page display real names (if available).  
> You can
> see an example of the output generated by this patch at
>
> http://xtuml.jdns.org/statcvs/user_u3957053.html
>
> Please note that only the page title is changed. No other output is  
> affected.
>
> I'll also post this on the SourceForge patch tracker.
>
> Regards,
> James
> -- 
> James Ring
> <author-page-real-name.patch>