#1469 STAFProc crashes on FS file copy

Unix
closed-fixed
5
2012-08-16
2012-08-14
toddq
No

Transferring the attached file with staf fs file copy as text causes STAFProc to crash. I don't know what's different about this particular file, it was generated by our test system. Transferring as binary works fine. Attempting transfer locally or remotely behaves the same. I've replicated the behavior on Linux and Mac going back several versions of STAF, including the current 3.4.10. It seems to work fine on Windows though. I'm guessing something involving line ending conversion is problematic.

Discussion

  • toddq

    toddq - 2012-08-14

    File used to reproduce problem.

     
  • Sharon Lucas

    Sharon Lucas - 2012-08-14

    I can recreate the crash on Linux. I'm investigating now.

     
  • Sharon Lucas

    Sharon Lucas - 2012-08-14
    • assigned_to: nobody --> slucas
     
  • Sharon Lucas

    Sharon Lucas - 2012-08-15

    Thank you for reporting this bug. I have fixed this bug in the FS service which could occur when copying a file using the TEXT option as well as when copying a directory using the TEXTEXT option. This issue only occurs when the text file being copied has line ending character(s) located at certain positions which cause an unsigned int variable in STAFFSService.cpp to be assigned -1 which results in it being assigned a large large number which causes a buffer overrun which causes STAFProc.to crash.

    This fix will be in the next release of STAF, V3.4.11, planned for the end of September 2012. If you would like a private fix now, I can provide you with an updated STAFProc binary for STAF V3.4.10 (that you can use to verify that the issue has been resolved) if you tell me for what operating system(s) you want it for (e.g. linux, linux-amd64, etc).

    Attached a file containing a cvs diff of the fix.

     
  • Sharon Lucas

    Sharon Lucas - 2012-08-15

    CVS Diff of Fix in STAFFSService.cpp

     
  • toddq

    toddq - 2012-08-16

    Thanks for the quick fix! We can wait for the next release.

     
  • Sharon Lucas

    Sharon Lucas - 2012-08-16
    • status: open --> closed-fixed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks