Thread: [SSI-devel] Re: [SSI-users] 1.1.1 quirks (cluster version and ps)
Brought to you by:
brucewalker,
rogertsang
From: Brian J. W. <Bri...@hp...> - 2004-10-27 21:30:10
|
Jose A. Rodriguez wrote: > Hi there, > > I'm just testing 1.1.1, and I found two minor quirks: > > 1) # cluster -r > This is cluster software release 1.1.0 > ^^^^^ > Should be 1.1.1 :) > > # rpm -q -f /bin/cluster # Do I have installed the right version? > cluster-tools-1.1.1-1devel I think the cluster command has the version hard-coded in it, and we forgot to update it before building this release. I'm not sure I like this feature being attached to the cluster command, which is really part of the CI project. The cluster-tools package doesn't change very quickly and doesn't need to be rebuilt for every release. Perhaps a solution that could work is that `cluster -r' returns the contents of /etc/openssi-release if it exists, otherwise it returns a hard-coded internal value that should correspond to its package version number. > BTW, I think it should be better to output just "1.1.1" so scripts can > use the version without removing the "This is cluster software..." > string. I agree. Brian |
From: <jos...@ac...> - 2004-10-28 06:47:46
|
> I'm not sure I like this feature being attached to the cluster command, > which is really part of the CI project. The cluster-tools package > doesn't change very quickly and doesn't need to be rebuilt for every > release. > > Perhaps a solution that could work is that `cluster -r' returns the > contents of /etc/openssi-release if it exists, otherwise it returns a > hard-coded internal value that should correspond to its package version > number. ... or let "cluster -r" show the CI release and /etc/openssi-release hold the OpenSSI version. This way you don't have to modify the cluster command, and it's easy to get all version numbers. Jose ____________________________________________________________________________ Jose A. Rodriguez OOO Universitat Politecnica de Catalunya (UPC) jo...@ac... OOO Departament d'Arquitectura de Computadors Tel. 16990 OOO -*- LCAC -*- UPC |
From: Brian J. W. <Bri...@hp...> - 2004-10-28 20:30:09
|
jos...@ac... wrote: > ... or let "cluster -r" show the CI release and > /etc/openssi-release hold the OpenSSI version. > > This way you don't have to modify the cluster command, and it's > easy to get all version numbers. That would certainly involve the least amount of work, since it's pretty much what we have right now. This might be an acceptable solution, as long as the cluster(1ssi) manpage and cluster usage message both made clear that it was returning the Cluster Infrastructure (CI) version number, not the OpenSSI version number. Does anybody else have an opinion on this? Brian |
From: Aneesh K. <ane...@gm...> - 2004-10-30 13:05:23
|
Hi Brian, On Thu, 28 Oct 2004 13:29:55 -0700, Brian J. Watson <bri...@hp...> wrote: > jos...@ac... wrote: > > ... or let "cluster -r" show the CI release and > > /etc/openssi-release hold the OpenSSI version. > > > > This way you don't have to modify the cluster command, and it's > > easy to get all version numbers. > > That would certainly involve the least amount of work, since it's pretty > much what we have right now. This might be an acceptable solution, as > long as the cluster(1ssi) manpage and cluster usage message both made > clear that it was returning the Cluster Infrastructure (CI) version > number, not the OpenSSI version number. > > Does anybody else have an opinion on this? > I guess we could add it as a note during the relese process to update the configure.ac file to indicate the release. Rest all are automated. I guess by doing this we could avoid a file read in case of cluster -r command. It could be made a release process. -aneesh |
From: Brian J. W. <Bri...@hp...> - 2004-11-01 17:37:30
|
Aneesh Kumar wrote: > I guess we could add it as a note during the relese process to update > the configure.ac file to indicate the release. Rest all are automated. > I guess by doing this we could avoid a file read in case of cluster -r > command. It could be made a release process. Does `cluster -r' hardcode its value based on ci/configure.ac? If so, that's better than what I thought it was. En Chiang and I (and perhaps Chirag and anybody else who's interested) are going to put some effort into updating the release procedure document and checking it into openssi/docs/devel. That way, it'll be clear what the exact procedure is, and it will be easy to modify whenever the procedure doesn't produce the correct results. One of the steps should certainly spell out every place that the release number needs to be bumped. Thanks, Brian |