[SSI-devel] [ ssic-linux-Bugs-1864069 ] non-paired lock/unlock in cfs_commit_inode

[SourceForge.net <no...@so...>]

Bugs item #1864069, was opened at 2008-01-04 12:12
Message generated for change (Comment added) made by rogertsang
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=405834&aid=1864069&group_id=32541

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: Filesystem
Group: v2.0.0pre1
Status: Open
>Resolution: Fixed
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: non-paired lock/unlock in cfs_commit_inode

Initial Comment:
In openssi/kernel/cluster/ssi/cfs/write.c we have:

int cfs_commit_inode(struct inode *inode, unsigned long idx_start,
                    unsigned int npages, int how)
{
        [...]
        spin_lock(&cfs_wreq_lock);
        res = cfs_scan_commit(inode, &head, idx_start, npages);
        spin_unlock(&cfs_wreq_lock);
        if (res) {
                res += cfs_scan_commit(inode, &head, 0, 0);
                spin_unlock(&cfs_wreq_lock);
                error = cfs_commit_list(&head, how);
        } else
                spin_unlock(&cfs_wreq_lock);

Looks like we're unlocking cfs_wreq_lock too many times.

----------------------------------------------------------------------

>Comment By: Roger Tsang (rogertsang)
Date: 2008-01-04 21:44

Message:
Logged In: YES 
user_id=1246761
Originator: NO

Fixed in latest CVS.
http://article.gmane.org/gmane.linux.cluster.ssic.cvs/8859
http://article.gmane.org/gmane.linux.cluster.ssic.cvs/8860

----------------------------------------------------------------------

Comment By: John Hughes (hughesj)
Date: 2008-01-04 17:41

Message:
Logged In: YES 
user_id=166336
Originator: NO

Aha, I'm working in a kernel that doesn't have the backported KERNEL2613
stuff.

But it's still a bug.




----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2008-01-04 16:32

Message:
Logged In: NO 

Since KERNEL2613 is defined by default this bug only affects those who
#undef KERNEL2613.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=405834&aid=1864069&group_id=32541