#84 fsck does not parse /etc/fstab rightly

closed
nobody
Filesystem (49)
5
2004-11-02
2004-10-29
Anonymous
No

The following /etc/fstab is not working properly on my
system:

/dev/hde1 / ext3 defaults,node=1 1 1
none /dev/pts devpts gid=5,mode=620,node=*
0 0
#none /dev/shm tmpfs
defaults 0 0
none /proc proc defaults,node=* 0 0
none /sys sysfs defaults,node=1 0 0
/dev/cdrom /mnt/cdrom udf,iso9660
noauto,owner,kudzu,ro,node=*
0 0
/dev/fd0 /mnt/floppy auto
noauto,owner,kudzu,node=* 0
0
# Nodes
/dev/hde2 /users/2 ext3 defaults,node=2
1 1
/dev/hde1 swap swap sw,node=2 0 0

- On boot time, node 1 fails (fsck error) because the
last lines (only for node 2). Removing them make node 1
boot with no problems.
- Executing "fsck -N -T -R -A -V" hangs or gives
"segmentation fault"

The problem is on openssi/e2fsprogs/misc/fsck.c file.
The function load_fs_info() tries to filter fstab
entries for a node ("node" option), but it fails to
maintain the global var "filesys_last" and the fs->next
pointers... So traversing the filesys_info fails in
the provided /etc/fstab.

I attatch a patch to fix this bug. Now the filtering
occurs on the parse_fstab_line() function. I think
that's safer than trying to remove a fs entry and fix
the global vars...

Discussion

  • Nobody/Anonymous

    Patch for openssi/e2fsprogs/misc/fsck.c

     
  • Nobody/Anonymous

    Logged In: NO

    BTW, my email is josear@ac.upc.es

     
  • Brian J. Watson

    Brian J. Watson - 2004-11-02

    Logged In: YES
    user_id=16302

    I checked in Jose's patch to the OPENSSI-FC branch. It will
    later be synced to the OPENSSI-RH branch. For some reason,
    the OPENSSI-DEBIAN branch had it already.

     
  • Brian J. Watson

    Brian J. Watson - 2004-11-02
    • status: open --> closed
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks