Re: [Sshpass-devel] Added support for entering TOTP; changing attempts entering password

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

<html style="direction: ltr;">
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
    <style id="bidiui-paragraph-margins" type="text/css">body p { margin-bottom: 0.3cm; margin-top: 0pt; } </style>
  </head>
  <body bidimailui-charset-is-forced="true" style="direction: ltr;">
    <p><br>
    </p>
    <div class="moz-cite-prefix">On 09/07/2021 12:39, Halturin Denis
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:DBA...@DB...">
      <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
      <style type="text/css" style="display:none;">P {margin-top:0;margin-bottom:0;}</style>
      Hello Shachar, <br>
      <span>Tell me, can I help with the review of my patch?</span>
      <div>
        <div style="font-family:Calibri,Helvetica,sans-serif;
          font-size:12pt; color:rgb(0,0,0)">
          <br>
        </div>
      </div>
    </blockquote>
    <p>Hello Denis,</p>
    <p>First, thank you for your patience. I'm overwhelmed by... life,
      and these things take time, unfortunately.</p>
    <p>My review for your patch is the same as it is for
      <a class="moz-txt-link-freetext" href="https://sourceforge.net/p/sshpass/patches/13/">https://sourceforge.net/p/sshpass/patches/13/</a>, trying to add Duo
      support. If you look at those patches you will notice they are
      very very <i>very</i> similar, and for pretty much the same
      reason.</p>
    <p>I can summarize both as "ssh added another type of prompt, and we
      want sshpass to support it".</p>
    <p>That's not the way to go. To understand why, just think what
      would happen if I accepted your patch today. It will be about a
      month until Debian Sid would carry it, and quite a few more months
      until Ubuntu would. I have no idea how long it would take for
      other distros to pick it up. All of that is assuming I am
      immediately responsive. As you have experienced, that is hardly
      the case.</p>
    <p>I'm not against sshpass supporting totp, or duo, or any other ssh
      plugin. I'm against it supporting those plugins individually.</p>
    <p>Sshpass already have a "-P" option for telling it what prompt to
      look out for. I understand why that is not always a good enough
      solution, but if that's the case for you, I would like a patch
      that provides a solution that is good enough <i>while also being
        generic</i>. Not adding support to TOTP, but "adding support for
      two password prompts in a row" (or whatever the reason that -P
      doesn't satisfy your need).</p>
    <p>Let's go through the release cycle once and solve this for as
      many ssh plugins as we can.</p>
    Shachar<br>
  </body>
</html>