#33 Typo in default password prompt indicator ("assword")

[Yan Yuhao]

Description

When running sshpass -V, the output shows an incorrect default password prompt indicator:

Using "assword" as the default password prompt indicator.

The expected value should be "password".

This appears to be a typo in configure.ac where the default PASSWORD_PROMPT is defined as "assword".

Steps to reproduce

sshpass -V

Output:

Using "assword" as the default password prompt indicator.

Expected behavior

The output should be:

Using "password" as the default password prompt indicator.

Proposed fix

The typo can be corrected in configure.ac by changing the default value of PASSWORD_PROMPT.

Patch:

diff --git a/configure.ac b/configure.ac
index 52ab2a1..d276aa7 100644
--- a/configure.ac
+++ b/configure.ac
@@ -35,7 +35,7 @@ AC_CHECK_FUNCS([select posix_openpt strdup])
 AC_ARG_ENABLE([password-prompt],
         [AS_HELP_STRING([--enable-password-prompt=prompt], [Provide alternative ssh password prompt to look for.])],
         [AC_DEFINE_UNQUOTED([PASSWORD_PROMPT], ["$enable_password_prompt"], [Password prompt to use])],

-        [AC_DEFINE([PASSWORD_PROMPT], ["assword"])])
+        [AC_DEFINE([PASSWORD_PROMPT], ["password"])])

 AC_CONFIG_FILES([Makefile])
 AM_CONFIG_HEADER(config.h)

Environment

sshpass -V

Output:

Using "assword" as the default password prompt indicator.

[Shachar Shemesh]

Hello Yan, and thank you for your approach.
This is, in fact, done on purpose. Some implementations use a lowercase "p" and others capital. By having the search pattern not include the first letter of the word, this matches both cases.