Re: [SSHGuard-users] [PATCH 1/1] sshguard.in: Fix race condition in exit trap

[Gregor H. <gre...@ew...>]

On Tue, May 27, 2025 at 11:42:52AM -0700, Kevin Zheng wrote:

Hi Kevin,
> On 5/23/25 4:36 AM, Gregor Herburger wrote:
> > When the sshguard script gets an SIGNAL to exit the clean_and_exit
> > function is called which calls exit which in turn calls exit 0. This can
> > in some cases call again clean_and_exit and causes a non-zero exit code.
> Thanks for the investigation and the patch.
> 
> The patch seems correct, though would you characterize it as a race
> condition or more of infinite recursion?
> 
Yes I think you are right, it is more of an infinite recursion.
Shall I reword the commit message and resend the patch?

> Could you also advise what OS/shell you were using when you encountered the
> issue?
This happend on a embedded linux system with busybox ash shell. Also
this only happens when the system is under heavy load.

Regards,
Gregor

-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
https://www.tq-group.com/