Re: [SSHGuard-users] sshguard 2.5.0 release candidate

[Kevin Z. <kev...@gm...>]

Hi Kevin,

Thanks for your testing and feedback.

> I have found that I can generate a tarball WITHOUT the doubled
> directories if I make this change

That's interesting. Neither `make dist` nor `make dist-bzip2` on my 
system results in these doubled directories. I wonder if something is 
subtly different about my system (because it's BSD)? You would think 
autoconf would pave over these differences...

In any case, your suggested patch that removes the trailing / seems to 
work for me, so I'm inclined to accept it.

Still, it would be good to understand what's going on...

> And finally, in terms of HTH feedback, the compilation warning
> messages from the rpmbuild on a SLES15sp5 system: just in case
> you feel like tidying everything up!

Could you check that the attached patch fixes some of the build warnings 
that you reported?

Regarding initgroups(): it seems like on BSD this is available in 
unistd.h, but on Linux it requires sys/types.h and grp.h. Could you test 
that this fixes the problem?

Regarding asprintf(): This apparently requires defining the feature test 
macro _GNU_SOURCE on Linux. Could you confirm that defining this fixes 
the warning, and also doesn't break things?

Regards,
Kevin