Re: [SSHGuard-users] sshguard 2.5.0 release candidate

[Kevin B. <kev...@gm...>]

On 2025/03/18 15:46, Kevin Buckley wrote:
> ...
> Deployed the RPM I was able to build to a test system.
> 
> It seems to be working as expected, even more so now that I'm
> not trying to "intrude" from a whitelisted address !

And finally, in terms of HTH feedback, the compilation warning
messages from the rpmbuild on a SLES15sp5 system: just in case
you feel like tidying everything up!

This set appears twice,

  make[2]: Entering directory '/usr/src/packages/BUILD/sshguard-2.5.0/src/blocker'
   CC       sandbox.o

make[3]: Entering directory '/usr/src/packages/BUILD/sshguard-2.5.0/src/parser'
   CC       sandbox.o

so presumably that componnet get rebuilt for the two functionalities


../common/sandbox.c: In function 'init_log':
../common/sandbox.c:14:18: warning: implicit declaration of function 'getenv'; did you mean 'getpw'? [-Wimplicit-function-declaration]
      int debug = (getenv("SSHGUARD_DEBUG") != NULL);
                   ^~~~~~
                   getpw
../common/sandbox.c:14:43: warning: comparison between pointer and integer
      int debug = (getenv("SSHGUARD_DEBUG") != NULL);
                                            ^~
../common/sandbox.c:26:5: warning: implicit declaration of function 'tzset' [-Wimplicit-function-declaration]
      tzset();
      ^~~~~
../common/sandbox.c: In function 'droproot':
../common/sandbox.c:33:9: warning: implicit declaration of function 'perror' [-Wimplicit-function-declaration]
          perror("Could not find user");
          ^~~~~~
../common/sandbox.c:36:9: warning: implicit declaration of function 'initgroups'; did you mean 'getgroups'? [-Wimplicit-function-declaration]
      if (initgroups(user, pw->pw_gid) == -1) {
          ^~~~~~~~~~
          getgroups
../common/sandbox.c: In function 'sandbox_init':
../common/sandbox.c:48:18: warning: initialization makes pointer from integer without a cast [-Wint-conversion]
      char *user = getenv("SSHGUARD_USER");
                   ^~~~~~


and then there's one last singleton:

make[3]: Entering directory '/usr/src/packages/BUILD/sshguard-2.5.0/src/parser'
   CC       metrics.o
../common/metrics.c: In function 'metrics_init':
../common/metrics.c:30:9: warning: implicit declaration of function 'asprintf'; did you mean 'vsprintf'? [-Wimplicit-function-declaration]
      if (asprintf(&stats_file_path, "%s/sshguard_%s.prom", stats_dir, name) < 0) {
          ^~~~~~~~
          vsprintf
make[3]: Leaving directory '/usr/src/packages/BUILD/sshguard-2.5.0/src/parser'



Another Kevin