[SSHGuard-maintainers] OpenSUSE defining _GNU_SOURCE [Was] SSHGuard 2.4.2 release announcement

[Kevin B. <kev...@gm...>]

On 2021/03/16 11:19, Kevin Zheng wrote:
> Dear SSHGuard users,
> 
> SSHGuard 2.4.2 is now available from SourceForge [1].

Just came to refresh the RPM that I've been creating so as to deploy
SSHGuard 2.4.2 here, and noticed that I still have a patch in my SPEC
files, which I took from a 2.4.0 SRPM that OpenSUSE was using that has
been  doing the following for a while now:

$ less ../SOURCES/sshguard-gcc5.patch
diff -crB sshguard-2.3.1/src/blocker/sshguard_whitelist.c sshguard-2.3.1-dev/src/blocker/sshguard_whitelist.c
*** sshguard-2.3.1/src/blocker/sshguard_whitelist.c     2018-12-16 03:41:51.000000000 +0100
--- sshguard-2.3.1/src/blocker/sshguard_whitelist.c     2019-01-24 09:34:29.600313298 +0100
***************
*** 18,23 ****
--- 18,24 ----
    * SSHGuard. See http://www.sshguard.net
    */
   
+ #define _GNU_SOURCE
   #include <arpa/inet.h>
   #include <assert.h>
   #include <netdb.h>


I haven't seen any OpenSUSE 2.4.2 SRPMs yet, but can still see the
patch in their 2.4.1 SRPM payload, vis:

$ rpm -qlp sshguard-2.4.1-42.10.src.rpm
warning: sshguard-2.4.1-42.10.src.rpm: Header V3 RSA/SHA256 Signature, key ID ee3d166a: NOKEY
sshguard-2.4.1.tar.gz
sshguard-gcc5.patch
sshguard.conf
sshguard.init
sshguard.service
sshguard.spec
sshguard.whitelist
$

and note in their 2.4.1 SPEC-file that is says

...
Source0:        http://sourceforge.net/projects/%{name}/files/%{name}/%{version}/%{name}-%{version}.tar.gz
Source1:        sshguard.conf
Source2:        sshguard.service
Source3:        sshguard.init
Source4:        sshguard.whitelist
# PATCH-FIX-UPSTREAM sshguard-gcc5.patch
Patch0:         sshguard-gcc5.patch
...

so was just wondering if there was a way to have that conditionally
defined, presumably for builds where one doesn't use a GNU compiler,
and/or whether it was indicative of some GNU-specific extensions used
in

sshguard_whitelist.c

Kevin Buckley